Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Side by Side Diff: chrome/browser/geolocation/geolocation_permission_context_android.cc

Issue 1240923002: Add an infobar to resolve android runtime permission mismatches. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address dfalcantara@ comment Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2012 The Chromium Authors. All rights reserved. 1 // Copyright 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/geolocation/geolocation_permission_context_android.h" 5 #include "chrome/browser/geolocation/geolocation_permission_context_android.h"
6 6
7 #include <vector>
8
9 #include "base/bind.h"
7 #include "chrome/browser/android/location_settings.h" 10 #include "chrome/browser/android/location_settings.h"
8 #include "chrome/browser/android/location_settings_impl.h" 11 #include "chrome/browser/android/location_settings_impl.h"
9 #include "chrome/browser/permissions/permission_request_id.h" 12 #include "chrome/browser/permissions/permission_request_id.h"
13 #include "chrome/browser/permissions/permission_update_infobar_delegate_android. h"
14 #include "content/public/browser/browser_thread.h"
10 #include "content/public/browser/web_contents.h" 15 #include "content/public/browser/web_contents.h"
11 #include "url/gurl.h" 16 #include "url/gurl.h"
12 17
13 GeolocationPermissionContextAndroid:: 18 GeolocationPermissionContextAndroid::
14 GeolocationPermissionContextAndroid(Profile* profile) 19 GeolocationPermissionContextAndroid(Profile* profile)
15 : GeolocationPermissionContext(profile), 20 : GeolocationPermissionContext(profile),
16 location_settings_(new LocationSettingsImpl()) { 21 location_settings_(new LocationSettingsImpl()),
22 weak_factory_(this) {
17 } 23 }
18 24
19 GeolocationPermissionContextAndroid::~GeolocationPermissionContextAndroid() { 25 GeolocationPermissionContextAndroid::~GeolocationPermissionContextAndroid() {
20 } 26 }
21 27
22 void GeolocationPermissionContextAndroid::RequestPermission( 28 void GeolocationPermissionContextAndroid::RequestPermission(
23 content::WebContents* web_contents, 29 content::WebContents* web_contents,
24 const PermissionRequestID& id, 30 const PermissionRequestID& id,
25 const GURL& requesting_frame_origin, 31 const GURL& requesting_frame_origin,
26 bool user_gesture, 32 bool user_gesture,
27 const BrowserPermissionCallback& callback) { 33 const BrowserPermissionCallback& callback) {
28 if (!location_settings_->CanSitesRequestLocationPermission(web_contents)) { 34 if (!location_settings_->CanSitesRequestLocationPermission(web_contents)) {
29 PermissionDecided(id, requesting_frame_origin, 35 PermissionDecided(id, requesting_frame_origin,
30 web_contents->GetLastCommittedURL().GetOrigin(), 36 web_contents->GetLastCommittedURL().GetOrigin(),
31 callback, false /* persist */, CONTENT_SETTING_BLOCK); 37 callback, false /* persist */, CONTENT_SETTING_BLOCK);
32 return; 38 return;
33 } 39 }
34 40
41 GURL embedding_origin = web_contents->GetLastCommittedURL().GetOrigin();
42 ContentSetting content_setting =
43 GeolocationPermissionContext::GetPermissionStatus(requesting_frame_origin,
44 embedding_origin);
45 std::vector<ContentSettingsType> content_settings_types;
46 content_settings_types.push_back(CONTENT_SETTINGS_TYPE_GEOLOCATION);
47 if (content_setting == CONTENT_SETTING_ALLOW &&
48 PermissionUpdateInfoBarDelegate::ShouldShowPermissionInfobar(
49 web_contents, content_settings_types)) {
50 PermissionUpdateInfoBarDelegate::Create(
51 web_contents, content_settings_types,
52 base::Bind(
53 &GeolocationPermissionContextAndroid
54 ::HandleUpdateAndroidPermissions,
Michael van Ouwerkerk 2015/07/22 09:41:26 nit: ws++++? not sure what the official way to wra
Ted C 2015/07/22 19:04:55 Done. Found a couple examples of this, so I'm con
55 weak_factory_.GetWeakPtr(), id, requesting_frame_origin,
56 embedding_origin, callback));
57 return;
58 }
59
35 GeolocationPermissionContext::RequestPermission( 60 GeolocationPermissionContext::RequestPermission(
36 web_contents, id, requesting_frame_origin, user_gesture, callback); 61 web_contents, id, requesting_frame_origin, user_gesture, callback);
37 } 62 }
38 63
64 void GeolocationPermissionContextAndroid::HandleUpdateAndroidPermissions(
65 const PermissionRequestID& id,
66 const GURL& requesting_frame_origin,
67 const GURL& embedding_origin,
68 const BrowserPermissionCallback& callback,
69 bool permissions_updated) {
70 DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
71 ContentSetting new_setting = permissions_updated
72 ? CONTENT_SETTING_ALLOW : CONTENT_SETTING_BLOCK;
73
74 NotifyPermissionSet(id, requesting_frame_origin, embedding_origin, callback,
75 false /* persist */, new_setting);
76 }
77
39 void GeolocationPermissionContextAndroid::SetLocationSettingsForTesting( 78 void GeolocationPermissionContextAndroid::SetLocationSettingsForTesting(
40 scoped_ptr<LocationSettings> settings) { 79 scoped_ptr<LocationSettings> settings) {
41 location_settings_ = settings.Pass(); 80 location_settings_ = settings.Pass();
42 } 81 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698