Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(538)

Issue 1240893003: documentation: more API details and examples. (Closed)

Created:
5 years, 5 months ago by hal.canary
Modified:
5 years, 4 months ago
Reviewers:
hcm
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

documentation: more API details and examples. NOTRY=true DOCS_PREVIEW= https://skia.org/user/api/skpaint?cl=1240893003 Committed: https://skia.googlesource.com/skia/+/a3a9ebcfb043b263d42c7d532ef487b99b9279fa

Patch Set 1 #

Patch Set 2 : 2015-07-16 (Thursday) 13:27:42 EDT #

Patch Set 3 : 2015-07-16 (Thursday) 13:43:08 EDT #

Patch Set 4 : 2015-07-16 (Thursday) 14:13:10 EDT #

Patch Set 5 : 2015-07-16 (Thursday) 14:19:05 EDT #

Patch Set 6 : 2015-07-16 (Thursday) 14:58:42 EDT #

Patch Set 7 : 2015-07-16 (Thursday) 17:20:37 EDT #

Patch Set 8 : 2015-07-16 (Thursday) 17:43:23 EDT #

Patch Set 9 : 2015-07-16 (Thursday) 18:31:34 EDT #

Patch Set 10 : 2015-07-16 (Thursday) 18:40:44 EDT #

Patch Set 11 : 2015-07-16 (Thursday) 18:41:52 EDT #

Total comments: 4

Patch Set 12 : 2015-07-27 (Monday) 15:23:50 EDT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+306 lines, -14 lines) Patch
M site/user/api/skpaint.md View 1 2 3 4 5 6 7 8 9 10 11 5 chunks +306 lines, -14 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
hal.canary
5 years, 5 months ago (2015-07-16 22:48:59 UTC) #2
hcm
Looks great, two minor, not-even-your-fault nits that would be nice to resolve. https://codereview.chromium.org/1240893003/diff/200001/site/user/api/skpaint.md File site/user/api/skpaint.md ...
5 years, 4 months ago (2015-07-27 19:22:04 UTC) #3
hal.canary
https://codereview.chromium.org/1240893003/diff/200001/site/user/api/skpaint.md File site/user/api/skpaint.md (right): https://codereview.chromium.org/1240893003/diff/200001/site/user/api/skpaint.md#newcode6 site/user/api/skpaint.md:6: <!-- Updated Jan 17, 2013 by humper@google.com --> On ...
5 years, 4 months ago (2015-07-27 19:24:38 UTC) #4
hcm
On 2015/07/27 19:24:38, Hal Canary wrote: > https://codereview.chromium.org/1240893003/diff/200001/site/user/api/skpaint.md > File site/user/api/skpaint.md (right): > > https://codereview.chromium.org/1240893003/diff/200001/site/user/api/skpaint.md#newcode6 ...
5 years, 4 months ago (2015-07-27 20:04:20 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1240893003/220001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1240893003/220001
5 years, 4 months ago (2015-07-27 20:12:40 UTC) #7
commit-bot: I haz the power
5 years, 4 months ago (2015-07-27 20:13:06 UTC) #8
Message was sent while issue was closed.
Committed patchset #12 (id:220001) as
https://skia.googlesource.com/skia/+/a3a9ebcfb043b263d42c7d532ef487b99b9279fa

Powered by Google App Engine
This is Rietveld 408576698