Slice MD downloads into more components

chrome/browser/resources/md_downloads/toolbar.js

+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+cr.define('downloads', function() {

[Jeremy Klein, 2015/07/16 18:54:54]

I wouldn't be surprised if the compiler pass does strange things here wrt to the
type of this element because it may not be aware of what cr.define is doing.
However, in Chrome world, the ChromePass does run before PolymerPass so maybe
the rewriting that ChromePass does is enough? Let's chat about the details here
offline.

[Dan Beam, 2015/07/18 01:02:20]

fwiw: we could also do

cr.exportPath('downloads');

downloads.Toolbar = Polymer(...);

+  var Toolbar = Polymer({
+    is: 'downloads-toolbar',
+
+    /** @param {!downloads.ActionService} actionService */
+    setActionService: function(actionService) {
+      /** @private {!downloads.ActionService} */
+      this.actionService_ = actionService;
+    },
+
+    properties: {
+      canClearAll: {
+        type: Boolean,
+        value: false,
+      },
+
+      showingSearch_: {
+        type: Boolean,
+        value: false,
+      },
+    },
+
+    ready: function() {
+      this.searchTerm = this.$['search-term'];

[Jeremy Klein, 2015/07/16 18:54:54]

Consider making searchTerm a declared property with a type specified. On the
other hand, I don't really like the idea of exposing an element in the local dom
as part of the public API unless it's totally necessary. Can we expose a
"hasUndo" function instead?

[Dan Beam, 2015/07/18 01:02:20]

Done.

+    },
+
+    /** @private */
+    onClearAllClick_: function() {
+      this.actionService_.clearAll();
+    },
+
+    /** @private */
+    onOpenDownloadsFolderClick_: function() {
+      this.actionService_.openDownloadsFolder();
+    },
+
+    /** @private */
+    toggleShowingSearch_: function() {
+      this.showingSearch_ = !this.showingSearch_;
+    },
+  });
+
+  return {Toolbar: Toolbar};
+});