Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 1240843004: Revert of components: Fix 'gn check' errors for omnibox. (Closed)

Created:
5 years, 5 months ago by kelvinp
Modified:
5 years, 5 months ago
CC:
chromium-reviews, Dirk Pranke
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of components: Fix 'gn check' errors for omnibox. (patchset #2 id:20001 of https://codereview.chromium.org/1232343006/) Reason for revert: This CL causes the Windows GN build to fail. Sample failure at http://build.chromium.org/p/chromium.win/builders/Win8%20GN%20%28dbg%29/builds/9607/steps/compile/logs/stdio Original issue's description: > components: Fix 'gn check' errors for omnibox. > > Tested on Linux with the following command lines: > > $ gn gen out-gn/Release --args='is_debug=false is_component_build=false symbol_level=1' > $ gn check out-gn/Release //components/omnibox/* > > BUG=367595, 376000 > TEST=see above > R=brettw@chromium.org,pkasting@chromium.org,skuhne@chromium.org > TBR=brettw@chromium.org > > Committed: https://crrev.com/fc240d37b0b23e1284ed943ea2a0830464190e20 > Cr-Commit-Position: refs/heads/master@{#339156} TBR=brettw@chromium.org,pkasting@chromium.org,skuhne@chromium.org,tfarina@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=367595, 376000 Committed: https://crrev.com/cc83d2d66b34ea56edba30cd90538fc1a3343e4f Cr-Commit-Position: refs/heads/master@{#339276}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -13 lines) Patch
M .gn View 1 chunk +0 lines, -2 lines 0 comments Download
M components/BUILD.gn View 1 chunk +1 line, -2 lines 0 comments Download
M components/omnibox/browser/BUILD.gn View 4 chunks +0 lines, -9 lines 0 comments Download
M components/sessions/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
kelvinp
Created Revert of components: Fix 'gn check' errors for omnibox.
5 years, 5 months ago (2015-07-17 17:13:08 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1240843004/1
5 years, 5 months ago (2015-07-17 17:13:46 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-17 17:15:24 UTC) #3
commit-bot: I haz the power
5 years, 5 months ago (2015-07-17 17:16:12 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cc83d2d66b34ea56edba30cd90538fc1a3343e4f
Cr-Commit-Position: refs/heads/master@{#339276}

Powered by Google App Engine
This is Rietveld 408576698