Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 1240793003: Remove views files from Mac GN build. (Closed)

Created:
5 years, 5 months ago by brettw
Modified:
5 years, 5 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove views files from Mac GN build. This makes the condition for adding chrome/browser/ui views files on Mac match the GYP build. Previously it was including these views files on all Mac builds, not just the mac_views_browser build. TBR=dpranke Committed: https://crrev.com/c62d9127ea2752970607c78fffcbc38022ecfbe0 Cr-Commit-Position: refs/heads/master@{#338931}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/ui/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (8 generated)
brettw
5 years, 5 months ago (2015-07-15 21:09:11 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1240793003/1
5 years, 5 months ago (2015-07-15 21:10:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1240793003/1
5 years, 5 months ago (2015-07-15 21:42:50 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1240793003/1
5 years, 5 months ago (2015-07-15 22:09:11 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-15 22:24:01 UTC) #13
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/c62d9127ea2752970607c78fffcbc38022ecfbe0 Cr-Commit-Position: refs/heads/master@{#338931}
5 years, 5 months ago (2015-07-15 22:26:00 UTC) #14
Dirk Pranke
5 years, 5 months ago (2015-07-15 22:42:49 UTC) #15
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698