Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1610)

Unified Diff: Source/modules/notifications/ServiceWorkerRegistrationNotifications.cpp

Issue 1240763002: CallbackPromiseAdapter types should be more compatible with WebCallbacks (3/3). (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: rebase Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/notifications/ServiceWorkerRegistrationNotifications.cpp
diff --git a/Source/modules/notifications/ServiceWorkerRegistrationNotifications.cpp b/Source/modules/notifications/ServiceWorkerRegistrationNotifications.cpp
index 73f95a2e3a031055a257b02fd59780b915a3058b..64cd3942f569e0567ed79b5ff3960213fbfe30b9 100644
--- a/Source/modules/notifications/ServiceWorkerRegistrationNotifications.cpp
+++ b/Source/modules/notifications/ServiceWorkerRegistrationNotifications.cpp
@@ -33,12 +33,12 @@ namespace {
// getNotifications() promise with a HeapVector owning Notifications.
class NotificationArray {
public:
- using WebType = OwnPtr<WebVector<WebPersistentNotificationInfo>>;
+ using WebType = const WebVector<WebPersistentNotificationInfo>&;
- static HeapVector<Member<Notification>> take(ScriptPromiseResolver* resolver, PassOwnPtr<WebVector<WebPersistentNotificationInfo>> notificationInfos)
+ static HeapVector<Member<Notification>> take(ScriptPromiseResolver* resolver, const WebVector<WebPersistentNotificationInfo>& notificationInfos)
{
HeapVector<Member<Notification>> notifications;
- for (const WebPersistentNotificationInfo& notificationInfo : *notificationInfos)
+ for (const WebPersistentNotificationInfo& notificationInfo : notificationInfos)
notifications.append(Notification::create(resolver->executionContext(), notificationInfo.persistentId, notificationInfo.data));
return notifications;
}
« no previous file with comments | « Source/modules/geofencing/GeofencingError.cpp ('k') | Source/modules/presentation/PresentationAvailability.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698