Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Unified Diff: public/platform/modules/push_messaging/WebPushProvider.h

Issue 1240763002: CallbackPromiseAdapter types should be more compatible with WebCallbacks (3/3). (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: public/platform/modules/push_messaging/WebPushProvider.h
diff --git a/public/platform/modules/push_messaging/WebPushProvider.h b/public/platform/modules/push_messaging/WebPushProvider.h
index e18726aca34b4fd8d8c41ca0a101c6afc412d407..cefc96117453fc9eb56aa5b04e67b7e44e7d9ad1 100644
--- a/public/platform/modules/push_messaging/WebPushProvider.h
+++ b/public/platform/modules/push_messaging/WebPushProvider.h
@@ -17,7 +17,7 @@ struct WebPushSubscriptionOptions;
using WebPushSubscriptionCallbacks = WebCallbacks<WebPushSubscription*, WebPushError*>;
using WebPushPermissionStatusCallbacks = WebCallbacks<WebPushPermissionStatus*, WebPushError*>;
Peter Beverloo 2015/07/27 17:30:09 Why can't we use const WebPushError& for these two
yhirano 2015/07/29 04:22:35 Yeah, that's possible and desirable but changing a
-using WebPushUnsubscribeCallbacks = WebCallbacks<bool*, WebPassOwnPtr<WebPushError>>;
+using WebPushUnsubscribeCallbacks = WebCallbacks<bool, const WebPushError&>;
class WebPushProvider {
public:

Powered by Google App Engine
This is Rietveld 408576698