Source/modules/serviceworkers/ServiceWorkerError.h - Issue 1240763002: CallbackPromiseAdapter types should be more compatible with WebCallbacks (3/3).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/serviceworkers/ServiceWorkerError.h

Issue 1240763002: CallbackPromiseAdapter types should be more compatible with WebCallbacks (3/3). (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/bindings/core/v8/CallbackPromiseAdapter.h ('K') | « Source/modules/serviceworkers/ServiceWorkerContainer.cpp ('k') | Source/modules/serviceworkers/ServiceWorkerError.cpp » ('j') | public/platform/modules/push_messaging/WebPushProvider.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/serviceworkers/ServiceWorkerError.h

diff --git a/Source/modules/serviceworkers/ServiceWorkerError.h b/Source/modules/serviceworkers/ServiceWorkerError.h

index d45644ca04d1bde52d14df902b2b8ef7e1375226..6166d76744b7e341517c71a55a6058fe8994143d 100644

--- a/Source/modules/serviceworkers/ServiceWorkerError.h

+++ b/Source/modules/serviceworkers/ServiceWorkerError.h

@@ -33,8 +33,6 @@

#include "platform/heap/Handle.h"

#include "public/platform/WebServiceWorkerError.h"

-#include "wtf/OwnPtr.h"

-#include "wtf/PassOwnPtr.h"

namespace blink {

@@ -44,8 +42,8 @@ class ScriptPromiseResolver;

class ServiceWorkerError {

public:

// For CallbackPromiseAdapter

- using WebType = OwnPtr<WebServiceWorkerError>;

- static DOMException* take(ScriptPromiseResolver*, PassOwnPtr<WebServiceWorkerError> webError);

+ using WebType = const WebServiceWorkerError&;

+ static DOMException* take(ScriptPromiseResolver*, const WebServiceWorkerError& webError);

private:

WTF_MAKE_NONCOPYABLE(ServiceWorkerError);