Source/modules/push_messaging/PushSubscriptionCallbacks.cpp - Issue 1240763002: CallbackPromiseAdapter types should be more compatible with WebCallbacks (3/3).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/push_messaging/PushSubscriptionCallbacks.cpp

Issue 1240763002: CallbackPromiseAdapter types should be more compatible with WebCallbacks (3/3). (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/bindings/core/v8/CallbackPromiseAdapter.h ('K') | « Source/modules/push_messaging/PushPermissionStatusCallbacks.cpp ('k') | Source/modules/serviceworkers/ServiceWorkerClients.cpp » ('j') | public/platform/modules/push_messaging/WebPushProvider.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/push_messaging/PushSubscriptionCallbacks.cpp

diff --git a/Source/modules/push_messaging/PushSubscriptionCallbacks.cpp b/Source/modules/push_messaging/PushSubscriptionCallbacks.cpp

index 546f3a748cf9c99d14bc1992f9b034d611174848..963350cd67787919ac43775a1867d61960380647 100644

--- a/Source/modules/push_messaging/PushSubscriptionCallbacks.cpp

+++ b/Source/modules/push_messaging/PushSubscriptionCallbacks.cpp

@@ -41,7 +41,7 @@ void PushSubscriptionCallbacks::onError(WebPushError* error)

OwnPtr<WebPushError> ownError = adoptPtr(error);

if (!m_resolver->executionContext() || m_resolver->executionContext()->activeDOMObjectsAreStopped())

return;

- m_resolver->reject(PushError::take(m_resolver.get(), ownError.release()));

+ m_resolver->reject(PushError::take(m_resolver.get(), *ownError));

}

} // namespace blink