Source/modules/push_messaging/PushError.h - Issue 1240763002: CallbackPromiseAdapter types should be more compatible with WebCallbacks (3/3).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/push_messaging/PushError.h

Issue 1240763002: CallbackPromiseAdapter types should be more compatible with WebCallbacks (3/3). (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/bindings/core/v8/CallbackPromiseAdapter.h ('K') | « Source/modules/presentation/PresentationError.cpp ('k') | Source/modules/push_messaging/PushError.cpp » ('j') | public/platform/modules/push_messaging/WebPushProvider.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/push_messaging/PushError.h

diff --git a/Source/modules/push_messaging/PushError.h b/Source/modules/push_messaging/PushError.h

index ee59bb9d732d6226725df3049ad87c1e8e52c9ad..ed38bb1126cfb34f90d1af5e729f8168d06a8e8e 100644

--- a/Source/modules/push_messaging/PushError.h

+++ b/Source/modules/push_messaging/PushError.h

@@ -8,8 +8,6 @@

#include "core/dom/DOMException.h"

#include "platform/heap/Handle.h"

#include "public/platform/modules/push_messaging/WebPushError.h"

-#include "wtf/OwnPtr.h"

-#include "wtf/PassOwnPtr.h"

namespace blink {

@@ -19,8 +17,8 @@ class PushError {

WTF_MAKE_NONCOPYABLE(PushError);

public:

// For CallbackPromiseAdapter.

- using WebType = OwnPtr<WebPushError>;

- static DOMException* take(ScriptPromiseResolver*, PassOwnPtr<WebPushError> webError);

+ using WebType = const WebPushError&;

+ static DOMException* take(ScriptPromiseResolver*, const WebPushError& webError);

private:

PushError() = delete;