Source/modules/app_banner/AppBannerPromptResult.h - Issue 1240763002: CallbackPromiseAdapter types should be more compatible with WebCallbacks (3/3).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/app_banner/AppBannerPromptResult.h

Issue 1240763002: CallbackPromiseAdapter types should be more compatible with WebCallbacks (3/3). (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/bindings/core/v8/CallbackPromiseAdapter.h ('K') | « Source/bindings/core/v8/CallbackPromiseAdapter.h ('k') | Source/modules/app_banner/AppBannerPromptResult.cpp » ('j') | public/platform/modules/push_messaging/WebPushProvider.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/app_banner/AppBannerPromptResult.h

diff --git a/Source/modules/app_banner/AppBannerPromptResult.h b/Source/modules/app_banner/AppBannerPromptResult.h

index cee172250a99c75fbaf553e4203889270b963650..3c0c4bf2f25c7398295b08bd935a26b33f715671 100644

--- a/Source/modules/app_banner/AppBannerPromptResult.h

+++ b/Source/modules/app_banner/AppBannerPromptResult.h

@@ -21,8 +21,8 @@ class AppBannerPromptResult final : public GarbageCollectedFinalized<AppBannerPr

WTF_MAKE_NONCOPYABLE(AppBannerPromptResult);

public:

// Support for CallbackPromiseAdapter:

- using WebType = OwnPtr<blink::WebAppBannerPromptResult>;

- static AppBannerPromptResult* take(ScriptPromiseResolver*, PassOwnPtr<WebAppBannerPromptResult> webInstance);

+ using WebType = const blink::WebAppBannerPromptResult&;

+ static AppBannerPromptResult* take(ScriptPromiseResolver*, const WebAppBannerPromptResult& webInstance);

static AppBannerPromptResult* create(const AtomicString& platform, WebAppBannerPromptResult::Outcome outcome)

{