Source/modules/geofencing/GeofencingError.cpp - Issue 1240763002: CallbackPromiseAdapter types should be more compatible with WebCallbacks (3/3).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/geofencing/GeofencingError.cpp

Issue 1240763002: CallbackPromiseAdapter types should be more compatible with WebCallbacks (3/3). (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/bindings/core/v8/CallbackPromiseAdapter.h ('K') | « Source/modules/geofencing/GeofencingError.h ('k') | Source/modules/notifications/ServiceWorkerRegistrationNotifications.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/geofencing/GeofencingError.cpp

diff --git a/Source/modules/geofencing/GeofencingError.cpp b/Source/modules/geofencing/GeofencingError.cpp

index ed53bcd7dc1c00f53571e5b4732eb9d56c90c0da..83fb24098caeb51341b9459d9f055b9febd8751e 100644

--- a/Source/modules/geofencing/GeofencingError.cpp

+++ b/Source/modules/geofencing/GeofencingError.cpp

@@ -10,13 +10,13 @@

namespace blink {

-DOMException* GeofencingError::take(ScriptPromiseResolver*, PassOwnPtr<WebGeofencingError> webError)

+DOMException* GeofencingError::take(ScriptPromiseResolver*, const WebGeofencingError& webError)

{

- switch (webError->errorType) {

+ switch (webError.errorType) {

case WebGeofencingError::ErrorTypeAbort:

- return DOMException::create(AbortError, webError->message);

+ return DOMException::create(AbortError, webError.message);

case WebGeofencingError::ErrorTypeUnknown:

- return DOMException::create(UnknownError, webError->message);

+ return DOMException::create(UnknownError, webError.message);

}

ASSERT_NOT_REACHED();

return DOMException::create(UnknownError);