Issue 1240753003: Revert[2] of guard to remove DrawBitmapRectFlags

Issue 1240753003: Revert[2] of guard to remove DrawBitmapRectFlags (Closed)

Created:
5 years, 5 months ago by reed1

Modified:
5 years, 5 months ago

Reviewers:
djsollen

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

Revert[2] of guard to remove DrawBitmapRectFlags This reverts commit 91110195a2eee170c11885da9d16f94b00a39f87. BUG=skia: TBR= Committed: https://skia.googlesource.com/skia/+/84984efeb64787b88c5f8bd6929cfe2d58a3ba06

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+77 lines, -55 lines)			Patch
M	bench/BitmapRectBench.cpp	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	bench/GameBench.cpp	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	gm/bitmaprect.cpp	View	1	3 chunks	+8 lines, -11 lines	0 comments	Download
M	gm/drawbitmaprect.cpp	View		4 chunks	+10 lines, -15 lines	0 comments	Download
M	gm/tallstretchedbitmaps.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	gm/verylargebitmap.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	gyp/skia_for_android_framework_defines.gypi	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	include/core/SkCanvas.h	View		5 chunks	+17 lines, -5 lines	0 comments	Download
M	samplecode/SampleApp.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	samplecode/SampleBitmapRect.cpp	View	1	2 chunks	+4 lines, -2 lines	0 comments	Download
M	samplecode/SampleTextureDomain.cpp	View	1	3 chunks	+4 lines, -4 lines	0 comments	Download
M	src/core/SkCanvas.cpp	View		4 chunks	+14 lines, -0 lines	0 comments	Download
M	src/effects/SkTestImageFilters.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/gpu/SkGr.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/utils/SkNinePatch.cpp	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/utils/debugger/SkDrawCommand.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tests/DrawBitmapRectTest.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tests/PictureTest.cpp	View	1	3 chunks	+4 lines, -4 lines	0 comments	Download
M	tests/SurfaceTest.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 5 (2 generated)

reed1

Now with compatibility fixes to build correctly w/ the legacy flag set.

5 years, 5 months ago (2015-07-17 13:55:09 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1240753003/20001

5 years, 5 months ago (2015-07-17 13:55:46 UTC) #4

commit-bot: I haz the power

5 years, 5 months ago (2015-07-17 14:09:48 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/84984efeb64787b88c5f8bd6929cfe2d58a3ba06