Add errorsAreFatal, onExit and onError parameters to the spawn functions.

Add errorsAreFatal, onExit and onError parameters to the spawn functions.

R=floitsch@google.com

Committed: https://github.com/dart-lang/sdk/commit/e4881c55d0774b3a2f90342e0212aa918ffd6445

[Lasse Reichstein Nielsen, 2015-07-15 12:09:57]

lrn@google.com changed reviewers:
+ floitsch@google.com, iposva@chromium.org

[floitsch, 2015-07-15 13:55:10]

LGTM.

https://codereview.chromium.org/1240743003/diff/1/sdk/lib/isolate/isolate.dart
File sdk/lib/isolate/isolate.dart (right):

https://codereview.chromium.org/1240743003/diff/1/sdk/lib/isolate/isolate.dar...
sdk/lib/isolate/isolate.dart:154: * You can also call the [setErrorsFatal],
[addOnExitListener] and
I would add a new line before.

https://codereview.chromium.org/1240743003/diff/1/sdk/lib/isolate/isolate.dar...
sdk/lib/isolate/isolate.dart:198: * You can call the [setErrorsFatal],
[addOnExitListener] and
ditto.

[kevmoo, 2015-07-15 13:58:01]

kevmoo@google.com changed reviewers:
+ kevmoo@google.com

[kevmoo, 2015-07-15 13:58:01]

DBQ: tests?

[floitsch, 2015-07-15 14:00:09]

On 2015/07/15 13:58:01, kevmoo wrote:
> DBQ: tests?

I would say tests make more sense when the functions are implemented. Less noise
(in the status files), and easier to write tests for something that doesn't just
throw.

[Ivan Posva, 2015-07-16 11:35:58]

iposva@google.com changed reviewers:
+ iposva@google.com
- iposva@chromium.org

[Ivan Posva, 2015-07-16 11:37:52]

-Ivan

https://codereview.chromium.org/1240743003/diff/1/sdk/lib/isolate/isolate.dart
File sdk/lib/isolate/isolate.dart (right):

https://codereview.chromium.org/1240743003/diff/1/sdk/lib/isolate/isolate.dar...
sdk/lib/isolate/isolate.dart:167: bool errorsAreFatal,
What is the default value for errorsAreFatal? I think this should be documented
here.

[Lasse Reichstein Nielsen, 2015-07-16 14:44:50]

https://codereview.chromium.org/1240743003/diff/1/sdk/lib/isolate/isolate.dart
File sdk/lib/isolate/isolate.dart (right):

https://codereview.chromium.org/1240743003/diff/1/sdk/lib/isolate/isolate.dar...
sdk/lib/isolate/isolate.dart:154: * You can also call the [setErrorsFatal],
[addOnExitListener] and
On 2015/07/15 13:55:09, floitsch wrote:
> I would add a new line before.

Done.

https://codereview.chromium.org/1240743003/diff/1/sdk/lib/isolate/isolate.dar...
sdk/lib/isolate/isolate.dart:167: bool errorsAreFatal,
I'm not sure there is one - browser isolates don't die on an error, VM isolates
do, so I guess "null" would mean the default behavior for the isolate, whatever
that is.

https://codereview.chromium.org/1240743003/diff/1/sdk/lib/isolate/isolate.dar...
sdk/lib/isolate/isolate.dart:198: * You can call the [setErrorsFatal],
[addOnExitListener] and
On 2015/07/15 13:55:10, floitsch wrote:
> ditto.

Done.

[Lasse Reichstein Nielsen, 2015-07-16 14:52:56]

Committed patchset #3 (id:40001) manually as
e4881c55d0774b3a2f90342e0212aa918ffd6445 (presubmit successful).