Issue 1240713004: Move FPDFAPI_FlateInit() prototype and friends to .h file

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1240713004: Move FPDFAPI_FlateInit() prototype and friends to .h file (Closed)

Created:
5 years, 5 months ago by Tom Sepez

Modified:
5 years, 5 months ago

Reviewers:
Lei Zhang

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Move FPDFAPI_FlateInit() prototype and friends to .h file R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/dacc22cdfea727a04bce086d9bfec9a4d1a29bd4

Patch Set 3 : Actually remove the loathsome include directive. #

Patch Set 4 : Copyright 2015 #

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+64 lines, -35 lines)			Patch
M	BUILD.gn	View		1 chunk	+1 line, -0 lines	0 comments	Download
A	core/include/fxcodec/fx_codec_flate.h	View	1 2 3	1 chunk	+26 lines, -0 lines	0 comments	Download
M	core/src/fpdfapi/fpdf_parser/fpdf_parser_filters.cpp	View	1 2	2 chunks	+14 lines, -18 lines	0 comments	Download
M	core/src/fxcodec/codec/fx_codec_flate.cpp	View		3 chunks	+22 lines, -17 lines	0 comments	Download
M	pdfium.gyp	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Tom Sepez

Lei, for review. This has the side-effect of fixing the issue found by checkdeps.

5 years, 5 months ago (2015-07-14 21:59:03 UTC) #2

Lei Zhang

lgtm https://codereview.chromium.org/1240713004/diff/20001/core/include/fxcodec/fx_codec_flate.h File core/include/fxcodec/fx_codec_flate.h (right): https://codereview.chromium.org/1240713004/diff/20001/core/include/fxcodec/fx_codec_flate.h#newcode1 core/include/fxcodec/fx_codec_flate.h:1: // Copyright 2014 PDFium Authors. All rights reserved. ...

5 years, 5 months ago (2015-07-14 23:17:47 UTC) #3

Tom Sepez

5 years, 5 months ago (2015-07-14 23:33:38 UTC) #4

Message was sent while issue was closed.

Committed patchset #4 (id:60001) manually as
dacc22cdfea727a04bce086d9bfec9a4d1a29bd4 (presubmit successful).