tools/perf/page_sets/extension_profile_shared_state.py - Issue 1240703003: Extension profile generator + benchmark for startup with profile.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tools/perf/page_sets/extension_profile_shared_state.py

Issue 1240703003: Extension profile generator + benchmark for startup with profile. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« tools/perf/benchmarks/start_with_ext.py ('K') | « tools/perf/page_sets/blank_page_with_extension_profile.py ('k') | tools/perf/profile_creators/extension_profile_extender.py » ('j') | tools/perf/profile_creators/extension_profile_extender.py » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 # Copyright 2015 The Chromium Authors. All rights reserved.

	2 # Use of this source code is governed by a BSD-style license that can be

	3 # found in the LICENSE file.

	4

	5 from profile_creators import profile_generator

	6 from profile_creators import extension_profile_extender

	7 from telemetry.page import shared_page_state

	8

	9

	10 class ExtensionProfileSharedState(shared_page_state.SharedPageState):

	11 def __init__(self, test, finder_options, story_set):

	12 super(ExtensionProfileSharedState, self).__init__(

	13 test, finder_options, story_set)

	14 generator = profile_generator.ProfileGenerator(

	15 extension_profile_extender.ExtensionProfileExtender,

	16 "extension_profile")

	17 out_dir = generator.Run(finder_options)
	erikchen 2015/07/14 23:36:14 Does this directory end up leaking? Does it magica Does this directory end up leaking? Does it magically get cached between runs? I see that you're just copying the logic from session_restore.py, but I wouldn't blindly trust that class. sydli 2015/07/15 22:56:23 Suppose it's "magically cached" since python's tem Show quoted text On 2015/07/14 23:36:14, erikchen wrote: > Does this directory end up leaking? Does it magically get cached between runs? I > see that you're just copying the logic from session_restore.py, but I wouldn't > blindly trust that class. Suppose it's "magically cached" since python's tempfile.tempdir uses the TMPDIR environment variable. Added code to clean up this directory using superclass TearDownState.
	18 print out_dir
	erikchen 2015/07/14 23:36:14 Did you mean to use a log statement here? Did you mean to use a log statement here? sydli 2015/07/15 22:56:23 Yeah; although I realize it's redundant since gene Show quoted text On 2015/07/14 23:36:14, erikchen wrote: > Did you mean to use a log statement here? Yeah; although I realize it's redundant since generate_profile also logs this directory. Deleted.
	19 if out_dir:

	20 finder_options.browser_options.profile_dir = out_dir

	21 else:

	22 finder_options.browser_options.dont_override_profile = True

	23

OLD	NEW