Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 1240663002: Canvas2d: Remove the updateAccessibility() method in HitRegion class. (Closed)

Created:
5 years, 5 months ago by zino
Modified:
5 years, 5 months ago
Reviewers:
Justin Novosad
CC:
blink-reviews, dshwang, Rik
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Canvas2d: Remove the updateAccessibility() method in HitRegion class. The method is duplicated with updateFocusRingElementAccessibility() in CRC2D. So, this CL is removing the duplicated method from HitRegion and renaming updateFocusRingElementAccessibility() to updateElementAccessibility(). BUG=328961 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198901

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -27 lines) Patch
M Source/modules/canvas2d/CanvasRenderingContext2D.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/canvas2d/CanvasRenderingContext2D.cpp View 1 3 chunks +5 lines, -3 lines 0 comments Download
M Source/modules/canvas2d/HitRegion.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/canvas2d/HitRegion.cpp View 1 chunk +0 lines, -22 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
zino
Please take a look. Thank you.
5 years, 5 months ago (2015-07-14 15:14:18 UTC) #4
Justin Novosad
On 2015/07/14 15:14:18, zino wrote: > Please take a look. > > Thank you. lgtm
5 years, 5 months ago (2015-07-14 18:36:22 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1240663002/20001
5 years, 5 months ago (2015-07-15 00:32:34 UTC) #7
commit-bot: I haz the power
5 years, 5 months ago (2015-07-15 00:58:50 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=198901

Powered by Google App Engine
This is Rietveld 408576698