Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(554)

Issue 1240653004: Update life-of-a-url-request.md: Replace IPCResourceLoaderBridge with RequestPeer (Closed)

Created:
5 years, 5 months ago by tyoshino (SeeGerritForStatus)
Modified:
5 years, 5 months ago
Reviewers:
eroman, mmenke
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update life-of-a-url-request.md: Replace IPCResourceLoaderBridge with RequestPeer IPCResourceLoaderBridge is gone. Each user implements RequestPeer and pass themselves to StartAsync() function. BUG=none Committed: https://crrev.com/ddef8b66b1a7a5627944b906e7d4579bf49d1568 Cr-Commit-Position: refs/heads/master@{#339462}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed #3 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -7 lines) Patch
M net/docs/life-of-a-url-request.md View 1 3 chunks +6 lines, -7 lines 0 comments Download

Messages

Total messages: 12 (3 generated)
tyoshino (SeeGerritForStatus)
5 years, 5 months ago (2015-07-17 12:09:08 UTC) #2
mmenke
In your CL comment, ResourcePeer should be replaced with RequestPeer (x2). Thanks for catching this! ...
5 years, 5 months ago (2015-07-17 12:29:34 UTC) #3
tyoshino (SeeGerritForStatus)
Fixed the description. Thanks! https://codereview.chromium.org/1240653004/diff/1/net/docs/life-of-a-url-request.md File net/docs/life-of-a-url-request.md (right): https://codereview.chromium.org/1240653004/diff/1/net/docs/life-of-a-url-request.md#newcode120 net/docs/life-of-a-url-request.md:120: ResourceDispatcher to start a request. ...
5 years, 5 months ago (2015-07-17 13:07:15 UTC) #4
mmenke
LGTM! I believe the old text about an IPCResourceLoaderBridge was actually accurate when I started ...
5 years, 5 months ago (2015-07-17 14:38:07 UTC) #5
eroman
hah, looks like I just duplicate this effort! https://codereview.chromium.org/1246563002/
5 years, 5 months ago (2015-07-18 21:32:49 UTC) #7
mmenke
Just going to CQ this myself, before I get anyone else sending me a CL ...
5 years, 5 months ago (2015-07-20 16:43:23 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1240653004/20001
5 years, 5 months ago (2015-07-20 16:44:03 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 5 months ago (2015-07-20 17:03:26 UTC) #11
commit-bot: I haz the power
5 years, 5 months ago (2015-07-20 17:04:07 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ddef8b66b1a7a5627944b906e7d4579bf49d1568
Cr-Commit-Position: refs/heads/master@{#339462}

Powered by Google App Engine
This is Rietveld 408576698