Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Unified Diff: chrome/browser/extensions/api/messaging/native_process_launcher.h

Issue 12406002: Pass ID of the calling extension to the native messaging host. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/messaging/native_process_launcher.h
diff --git a/chrome/browser/extensions/api/messaging/native_process_launcher.h b/chrome/browser/extensions/api/messaging/native_process_launcher.h
index f1b6483b9d15a813653691661bfcd0896341ab39..0924f13ae39b143bfb9002512147165443a7602a 100644
--- a/chrome/browser/extensions/api/messaging/native_process_launcher.h
+++ b/chrome/browser/extensions/api/messaging/native_process_launcher.h
@@ -8,6 +8,7 @@
#include "base/process.h"
#include "chrome/browser/extensions/api/messaging/native_message_process_host.h"
+class CommandLine;
class GURL;
namespace base {
@@ -53,7 +54,7 @@ class NativeProcessLauncher {
// Launches native messaging process.
static bool LaunchNativeProcess(
Matt Perry 2013/03/05 18:19:24 I think it would be better to have this method acc
Sergey Ulanov 2013/03/05 19:03:05 This method is protected and supposed to be called
Matt Perry 2013/03/05 19:14:25 Oh OK, that makes sense. nit: fix the variable na
- const base::FilePath& path,
+ const CommandLine& path,
base::PlatformFile* read_file,
base::PlatformFile* write_file);

Powered by Google App Engine
This is Rietveld 408576698