chrome/browser/extensions/extension_service.cc - Issue 1240573012: Extension syncing: Introduce a NeedsSync pref

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_service.cc

Issue 1240573012: Extension syncing: Introduce a NeedsSync pref (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ext_sync_uninstall

Patch Set: more cleanup; fix test Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/extensions/extension_service.cc

diff --git a/chrome/browser/extensions/extension_service.cc b/chrome/browser/extensions/extension_service.cc

index 4a1919f96453a0140328f7aaa1b20c8cef7b40b0..2e1913713e0aa84db1ca8becdcc0ff5ff4919a40 100644

--- a/chrome/browser/extensions/extension_service.cc

+++ b/chrome/browser/extensions/extension_service.cc

@@ -867,7 +867,7 @@ void ExtensionService::EnableExtension(const std::string& extension_id) {

content::Details<const Extension>(extension));

if (extension_sync_service_)

- extension_sync_service_->SyncEnableExtension(*extension);

+ extension_sync_service_->SyncExtensionChangeIfNeeded(*extension);

}

void ExtensionService::DisableExtension(const std::string& extension_id,

@@ -918,7 +918,7 @@ void ExtensionService::DisableExtension(const std::string& extension_id,

}

if (extension_sync_service_)

- extension_sync_service_->SyncDisableExtension(*extension);

+ extension_sync_service_->SyncExtensionChangeIfNeeded(*extension);

}

void ExtensionService::DisableUserExtensions(

« no previous file with comments | « no previous file | chrome/browser/extensions/extension_service_unittest.cc » ('j') | chrome/browser/extensions/extension_service_unittest.cc » ('J')