chrome/browser/extensions/extension_sync_data.cc - Issue 1240573012: Extension syncing: Introduce a NeedsSync pref

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_sync_data.cc

Issue 1240573012: Extension syncing: Introduce a NeedsSync pref (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ext_sync_uninstall

Patch Set: (b); hackfix sync_integration_tests Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/extension_service_unittest.cc ('K') | « chrome/browser/extensions/extension_service_unittest.cc ('k') | chrome/browser/extensions/extension_sync_service.h » ('j') | chrome/browser/extensions/extension_sync_service.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_sync_data.cc

diff --git a/chrome/browser/extensions/extension_sync_data.cc b/chrome/browser/extensions/extension_sync_data.cc

index bacf39c721a453894a7757ee9b4b7c0600e86617..6404e8b61ca690b75f3cea42094aaf779b885019 100644

--- a/chrome/browser/extensions/extension_sync_data.cc

+++ b/chrome/browser/extensions/extension_sync_data.cc

@@ -202,7 +202,7 @@ void ExtensionSyncData::ToAppSpecifics(sync_pb::AppSpecifics* specifics) const {

static_cast<sync_pb::AppSpecifics::LaunchType>(launch_type_);

// The corresponding validation of this value during processing of an

- // AppSyncData is in ExtensionSyncService::ProcessAppSyncData.

+ // ExtensionSyncData is in ExtensionSyncService::ApplySyncData.

if (launch_type_ >= LAUNCH_TYPE_FIRST && launch_type_ < NUM_LAUNCH_TYPES &&

sync_pb::AppSpecifics_LaunchType_IsValid(sync_launch_type)) {

specifics->set_launch_type(sync_launch_type);