Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(741)

Unified Diff: runtime/vm/assembler_x64.cc

Issue 1240573004: VM: Fix bug in x64 allocation tracing code. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/assembler_x64.cc
diff --git a/runtime/vm/assembler_x64.cc b/runtime/vm/assembler_x64.cc
index 7477651e67e5ae985df53a16da4e542fcb9176f5..1ed94881d5b3e3eb371d2da0f7955747ca5606c3 100644
--- a/runtime/vm/assembler_x64.cc
+++ b/runtime/vm/assembler_x64.cc
@@ -3492,6 +3492,7 @@ void Assembler::MaybeTraceAllocation(intptr_t cid,
// temp_reg gets address of class table pointer.
ClassTable* class_table = Isolate::Current()->class_table();
movq(temp_reg, Immediate(class_table->ClassStatsTableAddress()));
+ movq(temp_reg, Address(temp_reg, 0));
state_address = Address(temp_reg, class_offset + state_offset);
}
testb(state_address, Immediate(ClassHeapStats::TraceAllocationMask()));
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698