Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Unified Diff: go/src/infra/gae/libs/gae/prod/globalinfo.go

Issue 1240573002: Reland: Refactor current GAE abstraction library to be free of the SDK* (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master
Patch Set: expand coverage range to fit 32bit test expectations Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « go/src/infra/gae/libs/gae/prod/doc.go ('k') | go/src/infra/gae/libs/gae/prod/memcache.go » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: go/src/infra/gae/libs/gae/prod/globalinfo.go
diff --git a/go/src/infra/gae/libs/wrapper/gae/globalinfo.go b/go/src/infra/gae/libs/gae/prod/globalinfo.go
similarity index 69%
rename from go/src/infra/gae/libs/wrapper/gae/globalinfo.go
rename to go/src/infra/gae/libs/gae/prod/globalinfo.go
index c4988e0976ed7ec23ff5b2bb515b97d70318a17d..a315e1a9daa0bf810221f2d0f78c7f80dd025172 100644
--- a/go/src/infra/gae/libs/wrapper/gae/globalinfo.go
+++ b/go/src/infra/gae/libs/gae/prod/globalinfo.go
@@ -2,30 +2,27 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-package gae
+package prod
import (
"time"
"golang.org/x/net/context"
- "appengine"
+ "infra/gae/libs/gae"
- "infra/gae/libs/wrapper"
+ "google.golang.org/appengine"
)
-// useGI adds a wrapper.GlobalInfo implementation to context, accessible
-// by wrapper.GetGI(c)
+// useGI adds a gae.GlobalInfo implementation to context, accessible
+// by gae.GetGI(c)
func useGI(c context.Context) context.Context {
- return wrapper.SetGIFactory(c, func(ci context.Context) wrapper.GlobalInfo {
- return giImpl{ctx(c).Context, ci}
+ return gae.SetGIFactory(c, func(ci context.Context) gae.GlobalInfo {
+ return giImpl{ci}
})
}
-type giImpl struct {
- appengine.Context
- ctx context.Context
-}
+type giImpl struct{ context.Context }
func (g giImpl) AccessToken(scopes ...string) (token string, expiry time.Time, err error) {
return appengine.AccessToken(g, scopes...)
@@ -34,7 +31,7 @@ func (g giImpl) AppID() string {
return appengine.AppID(g)
}
func (g giImpl) Datacenter() string {
- return appengine.Datacenter()
+ return appengine.Datacenter(g)
}
func (g giImpl) DefaultVersionHostname() string {
return appengine.DefaultVersionHostname(g)
@@ -42,10 +39,7 @@ func (g giImpl) DefaultVersionHostname() string {
func (g giImpl) InstanceID() string {
return appengine.InstanceID()
}
-func (g giImpl) IsCapabilityDisabled(err error) bool {
- return appengine.IsCapabilityDisabled(err)
-}
-func (g giImpl) IsDevAppserver() bool {
+func (g giImpl) IsDevAppServer() bool {
return appengine.IsDevAppServer()
}
func (g giImpl) IsOverQuota(err error) bool {
@@ -61,14 +55,18 @@ func (g giImpl) ModuleName() (name string) {
return appengine.ModuleName(g)
}
func (g giImpl) Namespace(namespace string) (context.Context, error) {
- gaeC, err := appengine.Namespace(g, namespace)
+ return appengine.Namespace(g, namespace)
+}
+func (g giImpl) PublicCertificates() ([]gae.GICertificate, error) {
+ certs, err := appengine.PublicCertificates(g)
if err != nil {
return nil, err
}
- return context.WithValue(g.ctx, goonContextKey, gaeC), nil
-}
-func (g giImpl) PublicCertificates() ([]appengine.Certificate, error) {
- return appengine.PublicCertificates(g)
+ ret := make([]gae.GICertificate, len(certs))
+ for i, c := range certs {
+ ret[i] = (gae.GICertificate)(c)
+ }
+ return ret, nil
}
func (g giImpl) RequestID() string {
return appengine.RequestID(g)
« no previous file with comments | « go/src/infra/gae/libs/gae/prod/doc.go ('k') | go/src/infra/gae/libs/gae/prod/memcache.go » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698