Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Issue 1240503004: Revert of [XMLHttpRequest] Stop throwing for network error in async mode (Closed)

Created:
5 years, 5 months ago by Julien - ping for review
Modified:
5 years, 5 months ago
CC:
blink-reviews, tyoshino+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert of [XMLHttpRequest] Stop throwing for network error in async mode (patchset #8 id:140001 of https://codereview.chromium.org/1060113004/) Reason for revert: The test is causing browser_tests ExtensionApiTest.CrossOriginXHRNoFileAccess to fail on the Linux Chromium OS and the gn bots. Manually confirmed that it's the culprit with a gn component build on Linux. Relevant log: [FAIL] fileAccessNotAllowed: expected an error to be thrown Error at fileAccessNotAllowed (chrome-extension://dgmgifjgehkiibkkonbjcmcnagdegeco/test.js:24:21) at Object.\u003Canonymous> (extensions::test:95:19) at Object.handleRequest (extensions::binding:57:27) at Object.\u003Canonymous> (extensions::binding:385:32) at Object.\u003Canonymous> (extensions::test:326:16) at Object.handleRequest (extensions::binding:57:27) at Object.\u003Canonymous> (extensions::binding:385:32) at Object.callback (chrome-extension://dgmgifjgehkiibkkonbjcmcnagdegeco/test.js:6:15) at safeCallbackApply (extensions::sendRequest:21:15) at handleResponse (extensions::sendRequest:72:7)", source: chrome-extension://dgmgifjgehkiibkkonbjcmcnagdegeco/test.html (0) ../../chrome/browser/extensions/cross_origin_xhr_apitest.cc:37: Failure Value of: RunExtensionTestNoFileAccess( "cross_origin_xhr/no_file_access") Actual: false Expected: true Full log of the failure: https://build.chromium.org/p/chromium.webkit/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/17039/steps/browser_tests/logs/ExtensionApiTest.CrossOriginXHRNoFileAccess. Original issue's description: > [XMLHttpRequest] Stop throwing for network error in async mode > > See the history and decision at http://crbug.com/479484 > > This CL updates fast/files/apply-blob-url-to-xhr.html layout test to > stop expecting an exception but expect an error event being > dispatched. Using this opportunity, merged the worker version of the > test into one test script. > > security/cannot-read-self-from-file and > http/tests/xmlhttprequest/cross-origin-unsupported-url (and its worker > version) are simply updated to expect error event dispatching. > > BUG=479484 > R=sof,mkwst > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=199098 TBR=mkwst@chromium.org,sigbjornf@opera.com,tyoshino@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=479484 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=199120

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+120 lines, -172 lines) Patch
M LayoutTests/fast/files/apply-blob-url-to-xhr.html View 1 chunk +32 lines, -2 lines 0 comments Download
M LayoutTests/fast/files/apply-blob-url-to-xhr-expected.txt View 1 chunk +4 lines, -12 lines 0 comments Download
D LayoutTests/fast/files/resources/apply-blob-url-to-xhr.js View 1 chunk +0 lines, -97 lines 0 comments Download
A LayoutTests/fast/files/workers/resources/worker-apply-blob-url-to-xhr.js View 1 chunk +36 lines, -0 lines 0 comments Download
M LayoutTests/fast/files/workers/worker-apply-blob-url-to-xhr.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/files/workers/worker-apply-blob-url-to-xhr-expected.txt View 1 chunk +4 lines, -12 lines 0 comments Download
M LayoutTests/http/tests/xmlhttprequest/cross-origin-unsupported-url-expected.txt View 1 chunk +8 lines, -8 lines 0 comments Download
M LayoutTests/http/tests/xmlhttprequest/resources/cross-origin-unsupported-url.js View 1 chunk +18 lines, -1 line 0 comments Download
M LayoutTests/security/cannot-read-self-from-file.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/security/resources/cannot-read-self-from-file.html View 1 chunk +5 lines, -3 lines 0 comments Download
M Source/core/xmlhttprequest/XMLHttpRequest.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/xmlhttprequest/XMLHttpRequest.cpp View 2 chunks +11 lines, -33 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Julien - ping for review
Created Revert of [XMLHttpRequest] Stop throwing for network error in async mode
5 years, 5 months ago (2015-07-17 17:34:18 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1240503004/1
5 years, 5 months ago (2015-07-17 17:35:06 UTC) #2
commit-bot: I haz the power
5 years, 5 months ago (2015-07-17 17:36:03 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=199120

Powered by Google App Engine
This is Rietveld 408576698