Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 1240503002: reoder functions in the order they are normally executed (Closed)

Created:
5 years, 5 months ago by hubbe
Modified:
5 years, 5 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, gavinp+disk_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

reoder functions in the order they are normally executed See also https://codereview.chromium.org/1232223003/ Committed: https://crrev.com/7b8cfb94d4e9b4cc285a07a96e7feaf5d1ef1383 Cr-Commit-Position: refs/heads/master@{#338562}

Patch Set 1 #

Total comments: 2

Patch Set 2 : comments addressed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+496 lines, -495 lines) Patch
M net/http/http_cache_transaction.h View 1 2 chunks +37 lines, -34 lines 0 comments Download
M net/http/http_cache_transaction.cc View 1 15 chunks +459 lines, -461 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
hubbe
5 years, 5 months ago (2015-07-13 17:56:10 UTC) #2
rvargas (doing something else)
The header has to reflect the same order of methods. (that was not part of ...
5 years, 5 months ago (2015-07-13 19:18:56 UTC) #3
hubbe
merged https://codereview.chromium.org/1240503002/diff/1/net/http/http_cache_transaction.cc File net/http/http_cache_transaction.cc (left): https://codereview.chromium.org/1240503002/diff/1/net/http/http_cache_transaction.cc#oldcode1616 net/http/http_cache_transaction.cc:1616: On 2015/07/13 19:18:56, rvargas wrote: > need this ...
5 years, 5 months ago (2015-07-13 19:29:16 UTC) #4
rvargas (doing something else)
LGTM, Thanks!
5 years, 5 months ago (2015-07-13 20:55:04 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1240503002/20001
5 years, 5 months ago (2015-07-13 21:03:17 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 5 months ago (2015-07-13 21:12:05 UTC) #8
commit-bot: I haz the power
5 years, 5 months ago (2015-07-13 21:13:01 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7b8cfb94d4e9b4cc285a07a96e7feaf5d1ef1383
Cr-Commit-Position: refs/heads/master@{#338562}

Powered by Google App Engine
This is Rietveld 408576698