[es6] Implement inner scope for functions with destructuring

src/scopes.cc

Index: src/scopes.cc
diff --git a/src/scopes.cc b/src/scopes.cc
index d6a414b32050e2552b3405530fe323b0966e40e2..41622894a122d5a844788223bcc757f121585009 100644
--- a/src/scopes.cc
+++ b/src/scopes.cc
@@ -151,6 +151,9 @@ void Scope::SetDefaults(ScopeType scope_type, Scope* outer_scope,
                         FunctionKind function_kind) {
   outer_scope_ = outer_scope;
   scope_type_ = scope_type;
+  is_declaration_scope_ =
+      is_eval_scope() || is_function_scope() ||
+      is_module_scope() || is_script_scope();
   function_kind_ = function_kind;
   scope_name_ = ast_value_factory_->empty_string();
   dynamics_ = nullptr;
@@ -1363,7 +1366,7 @@ bool Scope::HasArgumentsParameter(Isolate* isolate) {
 
 void Scope::AllocateStackSlot(Variable* var) {
   if (is_block_scope()) {
-    DeclarationScope()->AllocateStackSlot(var);
+    outer_scope()->DeclarationScope()->AllocateStackSlot(var);

[caitp (gmail), 2015/07/13 16:00:51]

Won't DeclarationScope() get outer_scope() on its own if is_block_scope() is
true? It looks like it does

[rossberg, 2015/07/14 06:24:51]

Not if it is a block scope that is a declaration scope, which is exactly what
this CL introduces. Without this, you'd run into an infinite loop.

   } else {
     var->AllocateTo(VariableLocation::LOCAL, num_stack_slots_++);
   }