Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(372)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1240443003: Fix slow repaint object registration (Closed)

Created:
5 years, 5 months ago by trchen
Modified:
5 years, 5 months ago
Reviewers:
Ian Vollick
CC:
blink-reviews, pdr+renderingwatchlist_chromium.org, zoltan1, szager+layoutwatch_chromium.org, eae+blinkwatch, leviw+renderwatch, blink-reviews-rendering, jchaffraix+rendering
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Fix slow repaint object registration The LayoutView now paints background, so the special condition to accelerate frame scrolling with fixed root background should be updated as well. As a drive-by fix, this CL also corrects slow repaint object accounting so we no longer leak slow repaint object count. BUG=506002 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198894

Patch Set 1 #

Total comments: 6

Patch Set 2 : revise #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -36 lines) Patch
M Source/core/layout/LayoutBox.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/layout/LayoutBox.cpp View 1 1 chunk +27 lines, -0 lines 0 comments Download
M Source/core/layout/LayoutObject.h View 2 chunks +4 lines, -0 lines 0 comments Download
M Source/core/layout/LayoutObject.cpp View 1 4 chunks +15 lines, -36 lines 0 comments Download

Messages

Total messages: 15 (5 generated)
trchen
5 years, 5 months ago (2015-07-14 01:15:29 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1240443003/1
5 years, 5 months ago (2015-07-14 01:15:42 UTC) #4
Ian Vollick
https://codereview.chromium.org/1240443003/diff/1/Source/core/layout/LayoutBox.cpp File Source/core/layout/LayoutBox.cpp (right): https://codereview.chromium.org/1240443003/diff/1/Source/core/layout/LayoutBox.cpp#newcode252 Source/core/layout/LayoutBox.cpp:252: nit: extra ws. https://codereview.chromium.org/1240443003/diff/1/Source/core/layout/LayoutBox.cpp#newcode266 Source/core/layout/LayoutBox.cpp:266: bool isSlowRepaintObject = !isDocumentElement() ...
5 years, 5 months ago (2015-07-14 02:27:11 UTC) #5
trchen
https://codereview.chromium.org/1240443003/diff/1/Source/core/layout/LayoutBox.cpp File Source/core/layout/LayoutBox.cpp (right): https://codereview.chromium.org/1240443003/diff/1/Source/core/layout/LayoutBox.cpp#newcode252 Source/core/layout/LayoutBox.cpp:252: On 2015/07/14 02:27:11, vollick wrote: > nit: extra ws. ...
5 years, 5 months ago (2015-07-14 03:36:37 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1240443003/20001
5 years, 5 months ago (2015-07-14 03:36:56 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 5 months ago (2015-07-14 04:58:27 UTC) #10
Ian Vollick
On 2015/07/14 04:58:27, commit-bot: I haz the power wrote: > Dry run: This issue passed ...
5 years, 5 months ago (2015-07-14 23:14:34 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1240443003/20001
5 years, 5 months ago (2015-07-14 23:14:56 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://src.chromium.org/viewvc/blink?view=rev&revision=198894
5 years, 5 months ago (2015-07-14 23:19:01 UTC) #14
Noel Gordon
5 years, 5 months ago (2015-07-15 03:03:56 UTC) #15
Message was sent while issue was closed. 
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1224083019/ by noel@chromium.org.

The reason for reverting is: Speculative revert: appears to have broken Linux
MSAN bots.

http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20MSAN/bu...
.

Powered by Google App Engine
This is Rietveld 408576698