pkg/analysis_server/lib/src/services/completion/dart_completion_manager.dart - Issue 1240433008: Renames to move closer to the new API

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/lib/src/services/completion/dart_completion_manager.dart

Issue 1240433008: Renames to move closer to the new API (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/analysis_server/lib/src/services/completion/completion_manager.dart ('k') | pkg/analysis_server/test/domain_completion_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analysis_server/lib/src/services/completion/dart_completion_manager.dart

diff --git a/pkg/analysis_server/lib/src/services/completion/dart_completion_manager.dart b/pkg/analysis_server/lib/src/services/completion/dart_completion_manager.dart

index 88b78a4447f1315827aa6a2fa14b317d0ca3d7e5..9fb70bab53b14f87d7c808befc55bf91e758584f 100644

--- a/pkg/analysis_server/lib/src/services/completion/dart_completion_manager.dart

+++ b/pkg/analysis_server/lib/src/services/completion/dart_completion_manager.dart

@@ -42,8 +42,8 @@ const int DART_RELEVANCE_LOCAL_METHOD = 1057;

const int DART_RELEVANCE_LOCAL_TOP_LEVEL_VARIABLE = 1056;

const int DART_RELEVANCE_LOCAL_VARIABLE = 1059;

const int DART_RELEVANCE_LOW = 500;

-const int DART_RELEVANCE_PARAMETER = 1059;

const int DART_RELEVANCE_NAMED_PARAMETER = 1060;

+const int DART_RELEVANCE_PARAMETER = 1059;

/**

* The base class for contributing code completion suggestions.

@@ -222,7 +222,7 @@ class DartCompletionManager extends CompletionManager {

if (controller == null || controller.isClosed) {

return;

}

- controller.add(new CompletionResult(request.replacementOffset,

+ controller.add(new CompletionResultImpl(request.replacementOffset,

request.replacementLength, request.suggestions, last));

if (last) {

controller.close();