Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1007)

Unified Diff: Source/core/layout/LayoutVTTCue.h

Issue 1240433007: Separate VTTCue from VTTCueBox and LayoutVTTCue (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: empty constructor, explicit keyword Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/html/track/vtt/VTTCue.cpp ('k') | Source/core/layout/LayoutVTTCue.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/layout/LayoutVTTCue.h
diff --git a/Source/core/layout/LayoutVTTCue.h b/Source/core/layout/LayoutVTTCue.h
index b3236d8aeb690a986926123ca179c482429c1459..f4b861582df6a2c0083ed0d771aebf133c8f8311 100644
--- a/Source/core/layout/LayoutVTTCue.h
+++ b/Source/core/layout/LayoutVTTCue.h
@@ -31,12 +31,15 @@
namespace blink {
-class VTTCue;
class VTTCueBox;
class LayoutVTTCue final : public LayoutBlockFlow {
public:
- explicit LayoutVTTCue(VTTCueBox*);
+ LayoutVTTCue(ContainerNode*, float snapToLinesPosition);
+
+ // The computed line position for snap-to-lines layout, and NaN for
+ // non-snap-to-lines layout where no adjustment should take place.
+ float snapToLinesPosition() { return m_snapToLinesPosition; }
private:
void layout() override;
@@ -44,9 +47,7 @@ private:
void adjustForTopAndBottomMarginBorderAndPadding();
void repositionCueSnapToLinesNotSet();
- // VTTCue is kept alive by VTTCueBox.
- GC_PLUGIN_IGNORE("http://crbug.com/509911")
- VTTCue* m_cue;
+ float m_snapToLinesPosition;
};
} // namespace blink
« no previous file with comments | « Source/core/html/track/vtt/VTTCue.cpp ('k') | Source/core/layout/LayoutVTTCue.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698