Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(895)

Unified Diff: Source/core/html/track/vtt/VTTCue.h

Issue 1240433007: Separate VTTCue from VTTCueBox and LayoutVTTCue (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: empty constructor, explicit keyword Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/core/html/track/vtt/VTTCue.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/html/track/vtt/VTTCue.h
diff --git a/Source/core/html/track/vtt/VTTCue.h b/Source/core/html/track/vtt/VTTCue.h
index a0062d1e15dfc80977195e9c7ac3a085fc0fb429..18ec23e208a9be3221e242a818671565f7634f23 100644
--- a/Source/core/html/track/vtt/VTTCue.h
+++ b/Source/core/html/track/vtt/VTTCue.h
@@ -47,27 +47,29 @@ struct VTTDisplayParameters {
FloatPoint position;
float size;
CSSValueID direction;
+ CSSValueID textAlign;
CSSValueID writingMode;
+ float snapToLinesPosition;
};
class VTTCueBox final : public HTMLDivElement {
public:
- static PassRefPtrWillBeRawPtr<VTTCueBox> create(Document& document, VTTCue* cue)
+ static PassRefPtrWillBeRawPtr<VTTCueBox> create(Document& document)
{
- return adoptRefWillBeNoop(new VTTCueBox(document, cue));
+ return adoptRefWillBeNoop(new VTTCueBox(document));
}
- VTTCue* getCue() const { return m_cue; }
void applyCSSProperties(const VTTDisplayParameters&);
- DECLARE_VIRTUAL_TRACE();
-
private:
- VTTCueBox(Document&, VTTCue*);
+ explicit VTTCueBox(Document&);
LayoutObject* createLayoutObject(const ComputedStyle&) override;
- RawPtrWillBeMember<VTTCue> m_cue;
+ // The computed line position for snap-to-lines layout, and NaN for
+ // non-snap-to-lines layout where no adjustment should take place.
+ // This is set in applyCSSProperties and propagated to LayoutVTTCue.
+ float m_snapToLinesPosition;
};
class VTTCue final : public TextTrackCue {
« no previous file with comments | « no previous file | Source/core/html/track/vtt/VTTCue.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698