Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 1240393005: [Docking] Restores docked state for tab-less browser windows (Closed)

Created:
5 years, 5 months ago by varkha
Modified:
5 years, 5 months ago
Reviewers:
oshima, Peter Kasting
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Docking] Restores docked state for tab-less browser windows The CL that was supposed to fix that collided in CQ with https://codereview.chromium.org/1209033008. After that CL apps launched in a window have SHOW_STATE_DEFAULT initially and not SHOW_STATE_NORMAL as was assumed in https://codereview.chromium.org/1221193009. This patch makes the code path for docked state similar to maximized state and updates that unit test. BUG=271582 Committed: https://crrev.com/e8561982b478352dc1d159c3b060b094c3bff3ff Cr-Commit-Position: refs/heads/master@{#339727}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M chrome/browser/ui/views/frame/browser_view_interactive_uitest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/window_sizer/window_sizer.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (4 generated)
varkha
oshima@, please take a look. I have tested my previous CL before xdai@'s work so ...
5 years, 5 months ago (2015-07-21 18:30:44 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1240393005/1
5 years, 5 months ago (2015-07-21 18:31:02 UTC) #4
Peter Kasting
RS LGTM for OWNERS
5 years, 5 months ago (2015-07-21 18:40:09 UTC) #5
oshima
lgtm
5 years, 5 months ago (2015-07-21 19:15:01 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 5 months ago (2015-07-21 19:55:13 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1240393005/1
5 years, 5 months ago (2015-07-21 20:03:48 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-21 20:10:05 UTC) #11
commit-bot: I haz the power
5 years, 5 months ago (2015-07-21 20:12:07 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e8561982b478352dc1d159c3b060b094c3bff3ff
Cr-Commit-Position: refs/heads/master@{#339727}

Powered by Google App Engine
This is Rietveld 408576698