Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(810)

Issue 1240373002: Revert of [DevTools] Remove edited scripts from debugger agent, move knowledge to frontend. (Closed)

Created:
5 years, 5 months ago by pfeldman
Modified:
5 years, 5 months ago
Reviewers:
dgozman, sergeyv, yurys
CC:
blink-reviews, caseq+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert of [DevTools] Remove edited scripts from debugger agent, move knowledge to frontend. (patchset #4 id:60001 of https://codereview.chromium.org/1238103002/) Reason for revert: I'm not sure it works the right way with the extensions / resources panel. Original issue's description: > [DevTools] Remove edited scripts from debugger agent, move knowledge to frontend. > > Instead of requesting scripts through Page.getResourceContent, we should > use Debugger.getScriptSource. NetworkProject does that. > > A couple of race fixes along the way because of changed timings. > > BUG=none > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=199161 TBR=yurys@chromium.org,sergeyv@chromium.org,dgozman@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=none Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=199174

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+272 lines, -80 lines) Patch
M LayoutTests/http/tests/inspector/workspace-test.js View 1 chunk +0 lines, -3 lines 0 comments Download
M LayoutTests/inspector/profiler/agents-disabled-check-expected.txt View 1 chunk +2 lines, -0 lines 0 comments Download
A LayoutTests/inspector/sources/debugger/network-uisourcecode-provider.html View 1 chunk +167 lines, -0 lines 0 comments Download
A LayoutTests/inspector/sources/debugger/network-uisourcecode-provider-expected.txt View 1 chunk +38 lines, -0 lines 0 comments Download
M Source/core/inspector/InspectorDebuggerAgent.h View 3 chunks +3 lines, -0 lines 0 comments Download
M Source/core/inspector/InspectorDebuggerAgent.cpp View 4 chunks +21 lines, -1 line 0 comments Download
M Source/core/inspector/InspectorPageAgent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/PageDebuggerAgent.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/inspector/PageDebuggerAgent.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M Source/devtools/front_end/bindings/NetworkProject.js View 5 chunks +31 lines, -47 lines 0 comments Download
M Source/devtools/front_end/bindings/ResourceScriptMapping.js View 2 chunks +0 lines, -16 lines 0 comments Download
M Source/devtools/front_end/sdk/DebuggerModel.js View 1 chunk +2 lines, -11 lines 0 comments Download
M Source/devtools/front_end/workspace/UISourceCode.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
pfeldman
Created Revert of [DevTools] Remove edited scripts from debugger agent, move knowledge to frontend.
5 years, 5 months ago (2015-07-20 17:47:56 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1240373002/1
5 years, 5 months ago (2015-07-20 17:48:07 UTC) #2
commit-bot: I haz the power
5 years, 5 months ago (2015-07-20 17:48:47 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=199174

Powered by Google App Engine
This is Rietveld 408576698