NaCl: Copy PNaCl translator IRT interfaces to the Chromium side

NaCl: Copy PNaCl translator IRT interfaces to the Chromium side

Add a copy of the existing SRPC-based implementation --
native_client/src/untrusted/irt/irt_pnacl_translator_{compile,link}.c
-- to the Chromium side.  This will allow the two implementations to
be independently changed to remove use of SRPC.

In copying this code, I have made some changes to follow the Chromium
style:

 * Switching to C++ and using C++ comments
 * Using anon namespaces instead of "static"
 * "*" spacing (using clang-format)
 * "FooBar" function naming instead of "foo_bar"
 * Using the Chromium copyright notice

BUG=302078
TEST=e.g. NaClBrowserTestPnacl.PPAPICore in browser_tests
  (also manually tested with NaCl-side interface disabled, to ensure the
  Chromium-side one is really being used)

Committed: https://crrev.com/d735c8b9e7d1c2267d65a357e9a3541358e846e2
Cr-Commit-Position: refs/heads/master@{#339825}

[Mark Seaborn, 2015-07-21 18:47:36]

The CQ bit was checked by mseaborn@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-07-21 18:48:52]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1240343004/1

[Mark Seaborn, 2015-07-21 19:06:29]

mseaborn@chromium.org changed reviewers:
+ jvoung@chromium.org

[commit-bot: I haz the power, 2015-07-21 19:58:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-21 19:58:37]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_r...)

[jvoung (off chromium), 2015-07-21 21:58:06]

LGTM

https://codereview.chromium.org/1240343004/diff/1/ppapi/nacl_irt/irt_pnacl_tr...
File ppapi/nacl_irt/irt_pnacl_translator_compile.cc (right):

https://codereview.chromium.org/1240343004/diff/1/ppapi/nacl_irt/irt_pnacl_tr...
ppapi/nacl_irt/irt_pnacl_translator_compile.cc:6: #include <string.h>
Could use cstring

[Mark Seaborn, 2015-07-21 23:32:30]

https://codereview.chromium.org/1240343004/diff/1/ppapi/nacl_irt/irt_pnacl_tr...
File ppapi/nacl_irt/irt_pnacl_translator_compile.cc (right):

https://codereview.chromium.org/1240343004/diff/1/ppapi/nacl_irt/irt_pnacl_tr...
ppapi/nacl_irt/irt_pnacl_translator_compile.cc:6: #include <string.h>
On 2015/07/21 21:58:06, jvoung wrote:
> Could use cstring

To be honest, I don't actually know the difference.  cstring is relatively new
to me. :-)

Do you want me to make the change?

I see that string.h is still more popular in Chromium:

$ git grep 'include .string.h' | wc -l
1011
$ git grep 'include .cstring' | wc -l
120

[jvoung (off chromium), 2015-07-21 23:39:48]

https://codereview.chromium.org/1240343004/diff/1/ppapi/nacl_irt/irt_pnacl_tr...
File ppapi/nacl_irt/irt_pnacl_translator_compile.cc (right):

https://codereview.chromium.org/1240343004/diff/1/ppapi/nacl_irt/irt_pnacl_tr...
ppapi/nacl_irt/irt_pnacl_translator_compile.cc:6: #include <string.h>
On 2015/07/21 23:32:30, Mark Seaborn wrote:
> On 2015/07/21 21:58:06, jvoung wrote:
> > Could use cstring
> 
> To be honest, I don't actually know the difference.  cstring is relatively new
> to me. :-)
> 
> Do you want me to make the change?
> 
> I see that string.h is still more popular in Chromium:
> 
> $ git grep 'include .string.h' | wc -l
> 1011
> $ git grep 'include .cstring' | wc -l
> 120

As is is fine =)

I think the difference is that it also puts the functions in the std::
namespace?

[Mark Seaborn, 2015-07-21 23:44:14]

The CQ bit was checked by mseaborn@chromium.org

[commit-bot: I haz the power, 2015-07-21 23:44:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1240343004/1

[commit-bot: I haz the power, 2015-07-21 23:55:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-21 23:55:37]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Mark Seaborn, 2015-07-21 23:58:59]

mseaborn@chromium.org changed reviewers:
+ bbudge@chromium.org

[Mark Seaborn, 2015-07-21 23:59:30]

+bbudge for OWNERS sign off on the gyp/gn files.

[bbudge, 2015-07-22 01:26:56]

lgtm

[Mark Seaborn, 2015-07-22 02:49:47]

The CQ bit was checked by mseaborn@chromium.org

[commit-bot: I haz the power, 2015-07-22 02:50:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1240343004/1

[commit-bot: I haz the power, 2015-07-22 02:55:15]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-07-22 02:55:50]

Patchset 1 (id:??) landed as
https://crrev.com/d735c8b9e7d1c2267d65a357e9a3541358e846e2
Cr-Commit-Position: refs/heads/master@{#339825}