Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 1240333002: Convert google_apis_unittests to run exclusively on Swarming (Closed)

Created:
5 years, 5 months ago by M-A Ruel
Modified:
5 years, 5 months ago
Reviewers:
jam
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/a/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert google_apis_unittests to run exclusively on Swarming 0 configs already ran on Swarming 45 used to run locally and were converted: - chromium.chromiumos.json: Linux ChromiumOS Ozone Tests (1) - chromium.chromiumos.json: Linux ChromiumOS Tests (1) - chromium.chromiumos.json: Linux ChromiumOS Tests (dbg)(1) - chromium.fyi.json: CFI Linux - chromium.fyi.json: Chromium Win 10 - chromium.fyi.json: ClangToTLinux tester - chromium.fyi.json: ClangToTLinuxASan tester - chromium.fyi.json: ClangToTMac tester - chromium.fyi.json: ClangToTMacASan tester - chromium.fyi.json: ClangToTWin tester - chromium.fyi.json: ClangToTWin(dbg) tester - chromium.fyi.json: ClangToTWin(dll) tester - chromium.fyi.json: ClangToTWin64 tester - chromium.fyi.json: ClangToTWin64(dbg) tester - chromium.fyi.json: ClangToTWin64(dll) tester - chromium.fyi.json: CrWinAsan tester - chromium.fyi.json: CrWinAsan(dll) tester - chromium.fyi.json: CrWinClang tester - chromium.fyi.json: CrWinClang(dbg) tester - chromium.fyi.json: CrWinClang(shared) tester - chromium.fyi.json: CrWinClang64 tester - chromium.fyi.json: CrWinClang64(dbg) tester - chromium.fyi.json: CrWinClang64(dll) tester - chromium.fyi.json: CrWinClangLLD tester - chromium.fyi.json: Linux Trusty - chromium.fyi.json: Linux Trusty (dbg) - chromium.linux.json: Linux Tests - chromium.linux.json: Linux Tests (dbg)(1) - chromium.linux.json: Linux Tests (dbg)(1)(32) - chromium.mac.json: Mac10.10 Tests - chromium.mac.json: Mac10.6 Tests - chromium.mac.json: Mac10.8 Tests - chromium.mac.json: Mac10.9 Tests - chromium.mac.json: Mac10.9 Tests (dbg) - chromium.memory.fyi.json: Linux ChromeOS MSan Tests - chromium.memory.fyi.json: Linux MSan Tests - chromium.memory.fyi.json: Linux TSan Tests - chromium.memory.json: Linux ASan LSan Tests (1) - chromium.memory.json: Linux Chromium OS ASan LSan Tests (1) - chromium.webkit.json: Linux ChromiumOS Tests (1) - chromium.webkit.json: Linux ChromiumOS Tests (dbg)(1) - chromium.win.json: Vista Tests (1) - chromium.win.json: Win 7 Tests x64 (1) - chromium.win.json: Win7 Tests (1) - chromium.win.json: XP Tests (1) Ran: ./manage.py --convert google_apis_unittests R=jam@chromium.org BUG=98637, 512284 Committed: https://crrev.com/71e75d8043292d014a344ed2453dcb821aaaf6aa Cr-Commit-Position: refs/heads/master@{#339583}

Patch Set 1 #

Patch Set 2 : fix #

Patch Set 3 : fixed #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+164 lines, -9 lines) Patch
M build/gn_migration.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M google_apis/google_apis.gyp View 1 1 chunk +19 lines, -0 lines 0 comments Download
A + google_apis/google_apis_unittests.isolate View 1 2 1 chunk +9 lines, -9 lines 3 comments Download
M testing/buildbot/chromium.chromiumos.json View 3 chunks +9 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.fyi.json View 1 2 23 chunks +69 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.linux.json View 3 chunks +9 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.mac.json View 5 chunks +15 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.memory.json View 2 chunks +6 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.memory.fyi.json View 3 chunks +9 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.webkit.json View 2 chunks +6 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.win.json View 4 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (7 generated)
M-A Ruel
5 years, 5 months ago (2015-07-20 16:52:15 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1240333002/1
5 years, 5 months ago (2015-07-20 16:55:17 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/46936) mac_chromium_compile_dbg_ng on ...
5 years, 5 months ago (2015-07-20 16:58:33 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1240333002/20001
5 years, 5 months ago (2015-07-20 17:10:30 UTC) #7
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/80172)
5 years, 5 months ago (2015-07-20 17:41:38 UTC) #9
M-A Ruel
https://codereview.chromium.org/1240333002/diff/40001/google_apis/google_apis_unittests.isolate File google_apis/google_apis_unittests.isolate (right): https://codereview.chromium.org/1240333002/diff/40001/google_apis/google_apis_unittests.isolate#newcode18 google_apis/google_apis_unittests.isolate:18: '../chrome/test/data/drive/', This is sad bug fixing this is outside ...
5 years, 5 months ago (2015-07-20 20:36:53 UTC) #11
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1240333002/40001
5 years, 5 months ago (2015-07-20 20:37:42 UTC) #12
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 5 months ago (2015-07-20 22:31:37 UTC) #14
jam
lgtm https://codereview.chromium.org/1240333002/diff/40001/google_apis/google_apis_unittests.isolate File google_apis/google_apis_unittests.isolate (right): https://codereview.chromium.org/1240333002/diff/40001/google_apis/google_apis_unittests.isolate#newcode18 google_apis/google_apis_unittests.isolate:18: '../chrome/test/data/drive/', On 2015/07/20 20:36:53, M-A Ruel wrote: > ...
5 years, 5 months ago (2015-07-20 22:53:51 UTC) #15
M-A Ruel
https://codereview.chromium.org/1240333002/diff/40001/google_apis/google_apis_unittests.isolate File google_apis/google_apis_unittests.isolate (right): https://codereview.chromium.org/1240333002/diff/40001/google_apis/google_apis_unittests.isolate#newcode18 google_apis/google_apis_unittests.isolate:18: '../chrome/test/data/drive/', On 2015/07/20 22:53:50, jam wrote: > On 2015/07/20 ...
5 years, 5 months ago (2015-07-21 00:52:08 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1240333002/40001
5 years, 5 months ago (2015-07-21 00:52:32 UTC) #18
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 5 months ago (2015-07-21 00:58:36 UTC) #19
commit-bot: I haz the power
5 years, 5 months ago (2015-07-21 00:59:26 UTC) #20
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/71e75d8043292d014a344ed2453dcb821aaaf6aa
Cr-Commit-Position: refs/heads/master@{#339583}

Powered by Google App Engine
This is Rietveld 408576698