Issue 1240323005: Avoid heap allocation for binary search work stack.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1240323005: Avoid heap allocation for binary search work stack. (Closed)

Created:
5 years, 5 months ago by ascull

Modified:
5 years, 5 months ago

Reviewers:
jvoung (off chromium), Jim Stichnoth

CC:
native-client-reviews_googlegroups.com

Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Avoid heap allocation for binary search work stack. During switch lowering a binary search tree is created. The height of this tree is usually small so no need for heap allocation. BUG= R=jvoung@chromium.org, jvoung, stichnot Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=8447bbaebb4f0af42dc23b23d9171e4f4a6e04f0

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	src/IceTargetLoweringX86BaseImpl.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Total messages: 3 (0 generated)

ascull

This should make fix the Windows built too, but it is avoiding the problem rather ...

5 years, 5 months ago (2015-07-23 17:22:14 UTC) #1

ascull

5 years, 5 months ago (2015-07-23 18:41:22 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
8447bbaebb4f0af42dc23b23d9171e4f4a6e04f0 (tree was closed).