Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 1240323003: MSE: Update DTS by the same delta as PTS during partial append window trimming (Closed)

Created:
5 years, 5 months ago by wolenetz
Modified:
5 years, 5 months ago
Reviewers:
DaleCurtis
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MSE: Update DTS by the same delta as PTS during partial append window trimming To prevent spurious coded frame processing discontinuity detection for potentially incorrect streams with coded frames having decode time > presentation time, this change updates DTS by the same delta as PTS during partial append window trimming. This change is option 2 from comment 9 in bug 511128. BUG=511128 R=dalecurtis@chromium.org TEST=*/FrameProcessorTest.PartialAppendWindowFilterNoDiscontinuity_DtsAfterPts Committed: https://crrev.com/8ae18b073fadded47d523c1cd6496b1224b963b5 Cr-Commit-Position: refs/heads/master@{#339812}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fixes my self-nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -5 lines) Patch
M media/filters/frame_processor.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M media/filters/frame_processor_unittest.cc View 1 3 chunks +54 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1240323003/1
5 years, 5 months ago (2015-07-21 22:26:52 UTC) #2
wolenetz
Please take a look at patch set 1. Thank you!
5 years, 5 months ago (2015-07-21 22:27:20 UTC) #3
wolenetz
https://codereview.chromium.org/1240323003/diff/1/media/filters/frame_processor_unittest.cc File media/filters/frame_processor_unittest.cc (right): https://codereview.chromium.org/1240323003/diff/1/media/filters/frame_processor_unittest.cc#newcode696 media/filters/frame_processor_unittest.cc:696: append_window_start_ = base::TimeDelta::FromMilliseconds(0); hmm. this line is superfluous. I'll ...
5 years, 5 months ago (2015-07-21 23:37:40 UTC) #4
DaleCurtis
lgtm
5 years, 5 months ago (2015-07-21 23:47:49 UTC) #5
wolenetz
Thanks for review https://codereview.chromium.org/1240323003/diff/1/media/filters/frame_processor_unittest.cc File media/filters/frame_processor_unittest.cc (right): https://codereview.chromium.org/1240323003/diff/1/media/filters/frame_processor_unittest.cc#newcode696 media/filters/frame_processor_unittest.cc:696: append_window_start_ = base::TimeDelta::FromMilliseconds(0); On 2015/07/21 23:37:40, ...
5 years, 5 months ago (2015-07-21 23:56:34 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1240323003/20001
5 years, 5 months ago (2015-07-21 23:57:07 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 5 months ago (2015-07-22 01:23:40 UTC) #10
commit-bot: I haz the power
5 years, 5 months ago (2015-07-22 01:24:30 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8ae18b073fadded47d523c1cd6496b1224b963b5
Cr-Commit-Position: refs/heads/master@{#339812}

Powered by Google App Engine
This is Rietveld 408576698