Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 1240303002: Remove 'read_only': 1 from most .isolate files. (Closed)

Created:
5 years, 5 months ago by M-A Ruel
Modified:
5 years, 5 months ago
Reviewers:
jam
CC:
chromium-reviews, cbentzel+watch_chromium.org, erikwright+watch_chromium.org, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/a/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove 'read_only': 1 from most .isolate files. These were mostly due to blind copy-paste. read_only:1 is the default so there's no point in specifying it. As per crbug.com/342913, only unit_tests has issue with running from read only files. R=jam@chromium.org BUG=116251 Committed: https://crrev.com/94bc4db5e341fbda8ce8f2210c9fc6b056a82868 Cr-Commit-Position: refs/heads/master@{#339490}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -11 lines) Patch
M base/base_unittests.isolate View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser_tests.isolate View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/interactive_ui_tests.isolate View 1 chunk +0 lines, -1 line 0 comments Download
M components/nacl_helper_nonsfi_unittests.isolate View 1 chunk +0 lines, -1 line 0 comments Download
M components/nacl_loader_unittests.isolate View 1 chunk +0 lines, -1 line 0 comments Download
M crypto/crypto_unittests.isolate View 1 chunk +0 lines, -1 line 0 comments Download
M net/net_unittests.isolate View 1 chunk +0 lines, -1 line 0 comments Download
M skia/skia_unittests.isolate View 1 chunk +0 lines, -1 line 0 comments Download
M testing/chromoting/chromoting_integration_tests.isolate View 1 chunk +0 lines, -1 line 0 comments Download
M tools/mb/mb.py View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
M-A Ruel
Minor cleanup before starting to remove more stuff.
5 years, 5 months ago (2015-07-20 16:01:21 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1240303002/1
5 years, 5 months ago (2015-07-20 16:01:59 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/29711)
5 years, 5 months ago (2015-07-20 17:26:36 UTC) #5
jam
lgtm
5 years, 5 months ago (2015-07-20 18:37:10 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1240303002/1
5 years, 5 months ago (2015-07-20 19:11:10 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-20 19:45:52 UTC) #9
commit-bot: I haz the power
5 years, 5 months ago (2015-07-20 19:46:50 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/94bc4db5e341fbda8ce8f2210c9fc6b056a82868
Cr-Commit-Position: refs/heads/master@{#339490}

Powered by Google App Engine
This is Rietveld 408576698