Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 1240273002: [strong] Keep language mode consistent (Closed)

Created:
5 years, 5 months ago by rossberg
Modified:
5 years, 5 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev, conradw
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[strong] Keep language mode consistent R=mstarzinger@chromium.org BUG=v8:4312 LOG=N Committed: https://crrev.com/2e040f54e921924657dab01c9ccebf43c628be2d Cr-Commit-Position: refs/heads/master@{#29756}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -9 lines) Patch
M src/compiler/js-operator.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/parser.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M src/preparser.cc View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
rossberg
5 years, 5 months ago (2015-07-20 13:18:35 UTC) #1
Michael Starzinger
LGTM.
5 years, 5 months ago (2015-07-20 13:45:33 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1240273002/1
5 years, 5 months ago (2015-07-20 13:53:42 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-20 14:31:33 UTC) #5
commit-bot: I haz the power
5 years, 5 months ago (2015-07-20 14:31:46 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2e040f54e921924657dab01c9ccebf43c628be2d
Cr-Commit-Position: refs/heads/master@{#29756}

Powered by Google App Engine
This is Rietveld 408576698