Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(364)

Unified Diff: pkg/compiler/lib/src/cps_ir/cps_ir_tracer.dart

Issue 1240263002: dart2js cps: Streamline expressions and primitives. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/cps_ir/cps_ir_tracer.dart
diff --git a/pkg/compiler/lib/src/cps_ir/cps_ir_tracer.dart b/pkg/compiler/lib/src/cps_ir/cps_ir_tracer.dart
index 0064b6bf0bc0ff25d28b9d1e1cb3d21df5754312..c12affd6b3f8551661ea65ac2099997be861d653 100644
--- a/pkg/compiler/lib/src/cps_ir/cps_ir_tracer.dart
+++ b/pkg/compiler/lib/src/cps_ir/cps_ir_tracer.dart
@@ -228,11 +228,9 @@ class IRTracer extends TracerUtil implements cps_ir.Visitor {
}
visitSetMutableVariable(cps_ir.SetMutableVariable node) {
- String dummy = names.name(node);
String variable = names.name(node.variable.definition);
String value = formatReference(node.value);
- printStmt(dummy, 'SetMutableVariable $variable := $value');
- visit(node.body);
+ return 'SetMutableVariable $variable := $value';
}
String formatReference(cps_ir.Reference ref) {
@@ -267,12 +265,10 @@ class IRTracer extends TracerUtil implements cps_ir.Visitor {
}
visitSetField(cps_ir.SetField node) {
- String dummy = names.name(node);
String object = formatReference(node.object);
String field = node.field.name;
String value = formatReference(node.value);
- printStmt(dummy, 'SetField $object.$field = $value');
- visit(node.body);
+ return 'SetField $object.$field = $value';
}
visitGetField(cps_ir.GetField node) {
@@ -287,11 +283,9 @@ class IRTracer extends TracerUtil implements cps_ir.Visitor {
}
visitSetStatic(cps_ir.SetStatic node) {
- String dummy = names.name(node);
String element = node.element.name;
String value = formatReference(node.value);
- printStmt(dummy, 'SetStatic $element = $value');
- visit(node.body);
+ return 'SetStatic $element = $value';
}
visitGetLazyStatic(cps_ir.GetLazyStatic node) {
@@ -523,18 +517,6 @@ class BlockCollector implements cps_ir.Visitor {
visitUnreachable(cps_ir.Unreachable node) {
}
- visitSetMutableVariable(cps_ir.SetMutableVariable exp) {
- visit(exp.body);
- }
-
- visitSetField(cps_ir.SetField exp) {
- visit(exp.body);
- }
-
- visitSetStatic(cps_ir.SetStatic exp) {
- visit(exp.body);
- }
-
visitGetLazyStatic(cps_ir.GetLazyStatic exp) {
addEdgeToContinuation(exp.continuation);
}
@@ -659,6 +641,18 @@ class BlockCollector implements cps_ir.Visitor {
unexpectedNode(node);
}
+ visitSetMutableVariable(cps_ir.SetMutableVariable node) {
+ unexpectedNode(node);
+ }
+
+ visitSetField(cps_ir.SetField node) {
+ unexpectedNode(node);
+ }
+
+ visitSetStatic(cps_ir.SetStatic node) {
+ unexpectedNode(node);
+ }
+
@override
visitForeignCode(cps_ir.ForeignCode node) {
if (node.continuation != null) {

Powered by Google App Engine
This is Rietveld 408576698