Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Unified Diff: tests/isolate/isolate.status

Issue 1240243003: Skip some isolate/spawn tests on dart2js browser runs - they time out. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Rebase. Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/isolate/isolate.status
diff --git a/tests/isolate/isolate.status b/tests/isolate/isolate.status
index a683b6685587b992a3dd96e271194455cde52a80..41355d727aed1a57ec8fc11435bdd95078814199 100644
--- a/tests/isolate/isolate.status
+++ b/tests/isolate/isolate.status
@@ -58,9 +58,14 @@ message3_test/constMap: RuntimeError # Issue 21817
message3_test/constInstance: RuntimeError # Issue 21817
browser/issue_12474_test: CompileTimeError # Issue 22529
enum_const_test/02: RuntimeError # Issue 21817
-error_exit_at_spawn_test: Fail, Timeout # Issue 23876
-error_at_spawn_test: Fail, Timeout # Issue 23876
-exit_at_spawn_test: Fail, Timeout # Issue 23876
+error_exit_at_spawn_test: Fail # Issue 23876
+error_at_spawn_test: Fail # Issue 23876
+exit_at_spawn_test: Fail # Issue 23876
+
+[ $compiler == dart2js && $runtime != d8 ]
+error_exit_at_spawn_test: Skip # Issue 23876
+error_at_spawn_test: Skip # Issue 23876
+exit_at_spawn_test: Skip # Issue 23876
[ $compiler == dart2js && $jscl ]
spawn_uri_test: SkipByDesign # Loading another file is not supported in JS shell
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698