Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(657)

Issue 1240223003: Oilpan: remove unnecessary ENABLE(OILPAN) protections of trace() calls. (Closed)

Created:
5 years, 5 months ago by sof
Modified:
5 years, 5 months ago
Reviewers:
oilpan-reviews, haraken
CC:
blink-reviews, michaeln, jsbell+serviceworker_chromium.org, philipj_slow, falken, tzik, mlamouri+watch-blink_chromium.org, dshwang, serviceworker-reviews, Justin Novosad, nhiroki, feature-media-reviews_chromium.org, tommyw+watchlist_chromium.org, Rik, dgrogan, eric.carlson_apple.com, cmumford, horo+watch_chromium.org, kinuko+serviceworker, jsbell+idb_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Oilpan: remove unnecessary ENABLE(OILPAN) protections of trace() calls. For modules/, minimize the use of ENABLE(OILPAN) in trace implementations. R=haraken BUG=340522 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=199164

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -20 lines) Patch
M Source/modules/canvas2d/CanvasRenderingContext2D.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/modules/compositorworker/CompositorWorkerGlobalScope.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/modules/indexeddb/IDBDatabase.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/modules/indexeddb/IDBRequest.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/modules/mediasource/MediaSource.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/modules/mediastream/RTCPeerConnection.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/modules/serviceworkers/ServiceWorkerMessageEvent.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/modules/serviceworkers/ServiceWorkerScriptCachedMetadataHandler.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/modules/speech/SpeechRecognition.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/modules/webdatabase/InspectorDatabaseAgent.cpp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
sof
please take a look.
5 years, 5 months ago (2015-07-20 11:59:43 UTC) #2
haraken
LGTM
5 years, 5 months ago (2015-07-20 12:01:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1240223003/1
5 years, 5 months ago (2015-07-20 12:04:50 UTC) #5
commit-bot: I haz the power
5 years, 5 months ago (2015-07-20 13:00:07 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=199164

Powered by Google App Engine
This is Rietveld 408576698