Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 1240223002: Fix installing of SIMD object on global object. (Closed)

Created:
5 years, 5 months ago by Michael Starzinger
Modified:
5 years, 5 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix installing of SIMD object on global object. We should not install the SIMD object on the global object unless support for SIMD is actually turned on by the flag. Otherwise calling SIMD.Float32x4() will hit unreachable code. We accidentally SIMD. R=rossberg@chromium.org Committed: https://crrev.com/d4cd3f5ef32356be6717f6957933a354f18219e8 Cr-Commit-Position: refs/heads/master@{#29749}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M src/bootstrapper.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Michael Starzinger
Andreas: PTAL. Bill: FYI.
5 years, 5 months ago (2015-07-20 09:40:33 UTC) #2
rossberg
lgtm
5 years, 5 months ago (2015-07-20 10:33:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1240223002/1
5 years, 5 months ago (2015-07-20 10:35:27 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-20 10:37:47 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/d4cd3f5ef32356be6717f6957933a354f18219e8 Cr-Commit-Position: refs/heads/master@{#29749}
5 years, 5 months ago (2015-07-20 10:38:05 UTC) #7
bbudge-google
5 years, 5 months ago (2015-07-20 12:38:03 UTC) #9
Message was sent while issue was closed.
LGTM thanks

Powered by Google App Engine
This is Rietveld 408576698