Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2772)

Unified Diff: chrome/browser/browser_accessibility_manager.cc

Issue 12402: Don't reenter Webkit, while it waits for outgoing sync calls to complete. Thi... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 12 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/browser_accessibility_manager.cc
===================================================================
--- chrome/browser/browser_accessibility_manager.cc (revision 5826)
+++ chrome/browser/browser_accessibility_manager.cc (working copy)
@@ -108,6 +108,10 @@
members->render_widget_host_->process()->channel()) {
// Necessary for the send to keep the UI responsive.
msg->EnableMessagePumping();
+ // By default sync calls are unblocking, i.e if the receiver is an outgoing
+ // sync call, it will process received sync calls. Webkit is not reentrant.
+ // We don't want to reenter Webkit if it is in an outgoing sync call.
+ msg->set_unblock(false);
success = members->render_widget_host_->process()->channel()->
SendWithTimeout(msg, kAccessibilityMessageTimeOut);
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698