ui/native_theme/native_theme_mac.mm - Issue 1240193002: Tweaks to make the toolkit-views HTTP Auth dialog more Maccy on MAc

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/native_theme/native_theme_mac.mm

Issue 1240193002: Tweaks to make the toolkit-views HTTP Auth dialog more Maccy on MAc (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@20150720-ViewsBrowser-DisableCertificateDialog-PLUS-BORDERS

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/native_theme/native_theme_mac.mm

diff --git a/ui/native_theme/native_theme_mac.mm b/ui/native_theme/native_theme_mac.mm

index 324d319d4eff6f611cf0b5c411562e5675cf5eee..f126078eee9b947a97f4ea37927ad88a3e4f158d 100644

--- a/ui/native_theme/native_theme_mac.mm

+++ b/ui/native_theme/native_theme_mac.mm

@@ -42,8 +42,8 @@ const SkColor kMenuPopupBackgroundColor = SkColorSetARGB(251, 255, 255, 255);

const SkColor kMenuSeparatorColor = SkColorSetARGB(243, 228, 228, 228);

const SkColor kMenuBorderColor = SkColorSetARGB(60, 0, 0, 0);

-// Hardcoded color used for some existing dialogs in Chrome's Cocoa UI.

-const SkColor kDialogBackgroundColor = SkColorSetRGB(251, 251, 251);

+// New "webui-style" bubbles and dialogs on Mac use a white background.

+const SkColor kDialogBackgroundColor = SK_ColorWHITE;

// On 10.6 and 10.7 there is no way to get components from system colors. Here,

// system colors are just opaque objects that can paint themselves and otherwise

« no previous file with comments | « chrome/browser/ui/views/login_view.cc ('k') | ui/views/layout/layout_constants.h » ('j') | no next file with comments »