Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1600)

Unified Diff: chrome/browser/ui/views/login_view.cc

Issue 1240193002: Tweaks to make the toolkit-views HTTP Auth dialog more Maccy on MAc (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@20150720-ViewsBrowser-DisableCertificateDialog-PLUS-BORDERS
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ui/native_theme/native_theme_mac.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/login_view.cc
diff --git a/chrome/browser/ui/views/login_view.cc b/chrome/browser/ui/views/login_view.cc
index 4c97c282eac3c91d01974249fb8a6ddab92a9dd2..b109a5bf08feba36738f02f5c4bcf74df43e07a0 100644
--- a/chrome/browser/ui/views/login_view.cc
+++ b/chrome/browser/ui/views/login_view.cc
@@ -11,8 +11,13 @@
#include "ui/views/layout/grid_layout.h"
#include "ui/views/layout/layout_constants.h"
+#if defined(OS_MACOSX)
+static const int kMessageWidth = 365;
+static const int kTextfieldStackHorizontalSpacing = 10;
+#else
static const int kMessageWidth = 320;
static const int kTextfieldStackHorizontalSpacing = 30;
+#endif
using password_manager::LoginModel;
using views::GridLayout;
@@ -73,7 +78,12 @@ LoginView::LoginView(const base::string16& explanation,
layout->AddView(password_label_);
layout->AddView(password_field_);
+#if !defined(OS_MACOSX)
+ // TODO(tapted): Is this ever needed? DialogClientView already adds
+ // kRelatedControlVerticalSpacing to account for padding between the password
+ // field and the buttons.
layout->AddPaddingRow(0, views::kUnrelatedControlVerticalSpacing);
+#endif
if (login_model_)
login_model_->AddObserver(this);
« no previous file with comments | « no previous file | ui/native_theme/native_theme_mac.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698