Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1209)

Unified Diff: chrome/utility/media_galleries/picasa_albums_indexer.cc

Issue 1240183002: Update SplitString calls in chrome. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/utility/importer/nss_decryptor.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/utility/media_galleries/picasa_albums_indexer.cc
diff --git a/chrome/utility/media_galleries/picasa_albums_indexer.cc b/chrome/utility/media_galleries/picasa_albums_indexer.cc
index e99a1412f2015b8c2076167b188d8dc23f17b30d..7eded27db44bfe3654efd4ab982ded5d57cccf52 100644
--- a/chrome/utility/media_galleries/picasa_albums_indexer.cc
+++ b/chrome/utility/media_galleries/picasa_albums_indexer.cc
@@ -41,11 +41,9 @@ class PicasaINIParser : public INIParser {
if (section.find(kAlbumSectionHeader) == 0)
return;
- std::vector<std::string> containing_albums;
- base::SplitString(value, ',', &containing_albums);
- for (std::vector<std::string>::iterator it = containing_albums.begin();
- it != containing_albums.end(); ++it) {
- AlbumImagesMap::iterator album_map_it = albums_images_->find(*it);
+ for (const std::string& album : base::SplitString(
+ value, ",", base::TRIM_WHITESPACE, base::SPLIT_WANT_ALL)) {
+ AlbumImagesMap::iterator album_map_it = albums_images_->find(album);
// Ignore entry if the album uid is not listed among in |album_uids|
// in the constructor. Happens if the PMP and INI files are inconsistent.
« no previous file with comments | « chrome/utility/importer/nss_decryptor.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698