Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(414)

Unified Diff: chrome/renderer/page_load_histograms.cc

Issue 1240183002: Update SplitString calls in chrome. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/page_load_histograms.cc
diff --git a/chrome/renderer/page_load_histograms.cc b/chrome/renderer/page_load_histograms.cc
index 78c1d5f2a73eb2c0376d848c42d802752249a49a..f032204224350963e36be4e6bbe24806bbf9486f 100644
--- a/chrome/renderer/page_load_histograms.cc
+++ b/chrome/renderer/page_load_histograms.cc
@@ -165,9 +165,9 @@ bool ViaHeaderContains(WebFrame* frame, const std::string& via_value) {
// separated by a comma corresponds to a proxy. The value added by a proxy is
// not expected to contain any commas.
// Example., Via: 1.0 Compression proxy, 1.1 Google Instant Proxy Preview
- base::SplitString(
+ values = base::SplitString(
frame->dataSource()->response().httpHeaderField(kViaHeaderName).utf8(),
- ',', &values);
+ ",", base::TRIM_WHITESPACE, base::SPLIT_WANT_ALL);
return std::find(values.begin(), values.end(), via_value) != values.end();
}
« no previous file with comments | « chrome/renderer/media/chrome_key_systems.cc ('k') | chrome/renderer/safe_browsing/phishing_url_feature_extractor.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698