Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3312)

Unified Diff: chrome/browser/extensions/updater/extension_updater_unittest.cc

Issue 1240183002: Update SplitString calls in chrome. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/install_signer.cc ('k') | chrome/browser/io_thread.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/updater/extension_updater_unittest.cc
diff --git a/chrome/browser/extensions/updater/extension_updater_unittest.cc b/chrome/browser/extensions/updater/extension_updater_unittest.cc
index e4b7b7bd7e8ba315c41f05c7f68f80a79f857f4b..dc7c70d036f27b49165d90bebd1b0277b5dfb74c 100644
--- a/chrome/browser/extensions/updater/extension_updater_unittest.cc
+++ b/chrome/browser/extensions/updater/extension_updater_unittest.cc
@@ -557,11 +557,10 @@ static const int kUpdateFrequencySecs = 15;
// "foo", and "c" to "".
static void ExtractParameters(const std::string& params,
std::map<std::string, std::string>* result) {
- std::vector<std::string> pairs;
- base::SplitString(params, '&', &pairs);
- for (size_t i = 0; i < pairs.size(); i++) {
- std::vector<std::string> key_val;
- base::SplitString(pairs[i], '=', &key_val);
+ for (const std::string& pair : base::SplitString(
+ params, "&", base::TRIM_WHITESPACE, base::SPLIT_WANT_ALL)) {
+ std::vector<std::string> key_val = base::SplitString(
+ pair, "=", base::TRIM_WHITESPACE, base::SPLIT_WANT_ALL);
if (!key_val.empty()) {
std::string key = key_val[0];
EXPECT_TRUE(result->find(key) == result->end());
« no previous file with comments | « chrome/browser/extensions/install_signer.cc ('k') | chrome/browser/io_thread.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698