src/codec/SkCodec_libbmp.cpp - Issue 1240143002: Add the ability to decode a subset to SkCodec.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/codec/SkCodec_libbmp.cpp

Issue 1240143002: Add the ability to decode a subset to SkCodec. (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Update comment Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/codec/SkCodec_libbmp.cpp

diff --git a/src/codec/SkCodec_libbmp.cpp b/src/codec/SkCodec_libbmp.cpp

index 3ac4b0b8ab1828cbac4fe27bbdd373e9be4609e1..dd6d9011b95a78d4f5303bfacdef7dbff440fa5e 100644

--- a/src/codec/SkCodec_libbmp.cpp

+++ b/src/codec/SkCodec_libbmp.cpp

@@ -585,6 +585,10 @@ SkCodec::Result SkBmpCodec::onGetPixels(const SkImageInfo& dstInfo,

return kCouldNotRewind;

}

+ if (!opts.fSubset.isEmpty()) {

+ // Subsets are not supported.

+ return kUnimplemented;

+ }

if (dstInfo.dimensions() != this->getInfo().dimensions()) {

SkCodecPrintf("Error: scaling not supported.\n");

return kInvalidScale;