Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(719)

Issue 1240123004: Cleanup logic for deciding when to install linux sysroot (Closed)

Created:
5 years, 5 months ago by Sam Clegg
Modified:
5 years, 5 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cleanup logic for deciding when to install linux sysroot The only semantic change here is that the sysroot will be installed for ia32 cross builds by default, like it is for arm and mips already. BUG=504446 Committed: https://crrev.com/dd181aed3e76b963564500fe6f28731c9e33700c Cr-Commit-Position: refs/heads/master@{#339343}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -11 lines) Patch
M build/linux/sysroot_scripts/install-sysroot.py View 2 chunks +23 lines, -11 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Sam Clegg
5 years, 5 months ago (2015-07-17 20:07:38 UTC) #1
Sam Clegg
5 years, 5 months ago (2015-07-17 20:08:05 UTC) #3
Lei Zhang
lgtm
5 years, 5 months ago (2015-07-17 21:12:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1240123004/1
5 years, 5 months ago (2015-07-17 22:04:54 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-17 22:13:46 UTC) #7
commit-bot: I haz the power
5 years, 5 months ago (2015-07-17 22:15:51 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dd181aed3e76b963564500fe6f28731c9e33700c
Cr-Commit-Position: refs/heads/master@{#339343}

Powered by Google App Engine
This is Rietveld 408576698